Skip to content

[v14.x backport] src: create helper for reading Uint32BE - #35701

Closed
juanarbol wants to merge 1 commit into
nodejs:v14.x-stagingfrom
juanarbol:backport-34944-to-14.x
Closed

[v14.x backport] src: create helper for reading Uint32BE#35701
juanarbol wants to merge 1 commit into
nodejs:v14.x-stagingfrom
juanarbol:backport-34944-to-14.x

Conversation

@juanarbol

@juanarboljuanarbol commented Oct 18, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Refs: #34944

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v14.x labels Oct 18, 2020
@juanarbol
juanarbolforce-pushed the backport-34944-to-14.x branch from 87f66b5 to 02b9af1CompareOctober 18, 2020 23:03
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@BethGriggsBethGriggs added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 2, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 2, 2020
@nodejs-github-bot

nodejs-github-bot commented Dec 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34693/

BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
@juanarbol@BethGriggs
src: create helper for reading Uint32BE
7057d34
Fixes: #34827
Backport-PR-URL: #35701
PR-URL: #34944
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs

BethGriggs commented Dec 9, 2020

Copy link
Copy Markdown
Member

Landed in 7057d34

BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@juanarbol@BethGriggs
src: create helper for reading Uint32BE
28612ba
Fixes: #34827
Backport-PR-URL: #35701
PR-URL: #34944
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@juanarbol@BethGriggs
src: create helper for reading Uint32BE
f230039
Fixes: #34827
Backport-PR-URL: #35701
PR-URL: #34944
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@juanarbol
juanarbol deleted the backport-34944-to-14.x branch January 19, 2021 16:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BethGriggsBethGriggsBethGriggs approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juanarbol@nodejs-github-bot@BethGriggs