Uh oh!
There was an error while loading. Please reload this page.
Add a header in BUILDING.md - #35710
Conversation
Uh oh!
There was an error while loading. Please reload this page.
codecov-io
commented
Oct 19, 2020
Codecov Report
@@ Coverage Diff @@## master #35710 +/- ##
==========================================
+ Coverage 96.40% 96.41% +0.01%
==========================================
Files 220 220 Lines 73675 73675 ==========================================
+ Hits 71025 71033 +8 + Misses 2650 2642 -8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
The first commit message needs to be more descriptive. The subsequent commit message should be a "fixup" commit message or else squashed into the first. Otherwise, the bot will land it as a separate commit.
The content is might not be in the best place. It separates the macos firewall tool from Running Tests and those two things should go together. I think it's fine (better even?) for the install instructions to be located where they were before.
Trott
commented
Oct 20, 2020
Since the commit message needed only a small tweak, I rebased, squashed, and force-pushed. I hope I didn't mess up your workflow, and if I did, I apologize in advance! |
Trott
commented
Oct 20, 2020
Having second thoughts about my comment here. Maybe it's fine where it is. And if not, we can move it some other time. Sorry to leave a wall of comments and then walk back half of them. |
PoojaDurgad
commented
Oct 20, 2020
@Trott - no problem. thanks |
PR-URL: nodejs#35710 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
commented
Oct 22, 2020
Landed in 1ba932b |
PR-URL: #35710 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #35710 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #35710 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #35710 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes