Uh oh!
There was an error while loading. Please reload this page.
add a subsystems header in pull-requests.md - #35718
Closed
PoojaDurgad wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
Oct 20, 2020
Collaborator
Review requested:
|
Trott
approved these changes
Oct 20, 2020
Trott
left a comment
Member
There was a problem hiding this comment.
Looks good to me. Some optional ideas:
Because the subsystem list is copy/pasted from
doc/guides/onboarding-extras.md, remove it from that document.Change the subsystem header to
Appendix: Subsystems
Codecov Report
@@ Coverage Diff @@## master #35718 +/- ##
=======================================
Coverage 96.40% 96.40% =======================================
Files 220 220 Lines 73675 73676 +1 =======================================
+ Hits 71025 71028 +3 + Misses 2650 2648 -2
Continue to review full report at Codecov.
|
Trott
approved these changes
Oct 21, 2020
jasnell
approved these changes
Oct 26, 2020
gireeshpunathil
approved these changes
Oct 27, 2020
Contributor
Landed in 16b2bc0...8f1e4d3 |
nodejs-github-bot pushed a commit
that referenced
this pull request
Oct 27, 2020
PR-URL: #35718 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35718 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs pushed a commit
that referenced
this pull request
Dec 8, 2020
PR-URL: #35718 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs pushed a commit
that referenced
this pull request
Dec 10, 2020
PR-URL: #35718 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Dec 15, 2020
PR-URL: #35718 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes