Skip to content

test: fix heap-profiler link error LNK1194 on win - #3572

Closed
john-yan wants to merge 1 commit into
nodejs:masterfrom
john-yan:heap-profiler-fix
Closed

test: fix heap-profiler link error LNK1194 on win#3572
john-yan wants to merge 1 commit into
nodejs:masterfrom
john-yan:heap-profiler-fix

Conversation

@john-yan

Copy link
Copy Markdown

Fix the following error on windows with VS 2013:

LINK : fatal error LNK1194: cannot delay-load 'node.exe' due to import of data symbol '"__declspec(dllimport) const v8::OutputStream::`vftable'" (__imp_??_7OutputStream@v8@@6B@)'; link without /DELAYLOAD:node.exe [K:\johnyan\node\test\addons\heap-profiler\build\binding.vcxproj]

@bnoordhuis

Copy link
Copy Markdown
Member

LGTM but can you update the commit log to include the error message?

Fix the following error message in windows using VS 2013
LINK : fatal error LNK1194: cannot delay-load 'node.exe'
due to import of data symbol '"__declspec(dllimport)
const v8::OutputStream::`vftable'"
(__imp_??_7OutputStream@v8@@6b@)'; link without
/DELAYLOAD:node.exe
@mscdexmscdex added windows Issues and PRs related to the Windows platform. test Issues and PRs related to the tests. labels Oct 28, 2015
@john-yan

Copy link
Copy Markdown
Author

@bnoordhuis commit log is updated. Please check if I am doing the right thing. Thanks.

@john-yan

Copy link
Copy Markdown
Author

can someone help add the lts-watch-v4.x tag? thanks.

bnoordhuis pushed a commit that referenced this pull request Oct 28, 2015
Fix the following error message in windows using VS 2013:
LINK : fatal error LNK1194: cannot delay-load 'node.exe'
due to import of data symbol '"__declspec(dllimport)
const v8::OutputStream::`vftable'"
(__imp_??_7OutputStream@v8@@6b@)'; link without
/DELAYLOAD:node.exe
PR-URL: #3572
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@bnoordhuis

Copy link
Copy Markdown
Member

Thanks, tagged and landed in 9f96705.

@john-yan
john-yan deleted the heap-profiler-fix branch October 28, 2015 20:16
rvagg pushed a commit to rvagg/io.js that referenced this pull request Oct 29, 2015
Fix the following error message in windows using VS 2013:
LINK : fatal error LNK1194: cannot delay-load 'node.exe'
due to import of data symbol '"__declspec(dllimport)
const v8::OutputStream::`vftable'"
(__imp_??_7OutputStream@v8@@6b@)'; link without
/DELAYLOAD:node.exe
PR-URL: nodejs#3572
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@rvaggrvagg mentioned this pull request Oct 29, 2015
john-yan pushed a commit to ibmruntimes/node that referenced this pull request Oct 29, 2015
Fix the following error message in windows using VS 2013:
LINK : fatal error LNK1194: cannot delay-load 'node.exe'
due to import of data symbol '"__declspec(dllimport)
const v8::OutputStream::`vftable'"
(__imp_??_7OutputStream@v8@@6b@)'; link without
/DELAYLOAD:node.exe
PR-URL: nodejs/node#3572
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
jasnell pushed a commit that referenced this pull request Oct 29, 2015
Fix the following error message in windows using VS 2013:
LINK : fatal error LNK1194: cannot delay-load 'node.exe'
due to import of data symbol '"__declspec(dllimport)
const v8::OutputStream::`vftable'"
(__imp_??_7OutputStream@v8@@6b@)'; link without
/DELAYLOAD:node.exe
PR-URL: #3572
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
jasnell pushed a commit that referenced this pull request Oct 29, 2015
Fix the following error message in windows using VS 2013:
LINK : fatal error LNK1194: cannot delay-load 'node.exe'
due to import of data symbol '"__declspec(dllimport)
const v8::OutputStream::`vftable'"
(__imp_??_7OutputStream@v8@@6b@)'; link without
/DELAYLOAD:node.exe
PR-URL: #3572
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@jasnell

Copy link
Copy Markdown
Member

Landed in v4.x-staging in a8c24ce

@alexhuang100

Copy link
Copy Markdown

I have the same issue ,but without solved by using adding 'win_delay_load_hook': 'false',
Nodejs version:v0.12.15
node-gyp vesion:v3.4.0
OS: windows 7
VS:2015 community

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testIssues and PRs related to the tests.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@john-yan@bnoordhuis@jasnell@alexhuang100@mscdex