Uh oh!
There was an error while loading. Please reload this page.
doc: made code spans more visible - #3573
Closed
phillipj wants to merge 1 commit into
Closed
Conversation
evanlucas
commented
Oct 29, 2015
Contributor
LGTM |
Contributor
There was a problem hiding this comment.
I think a padding of 0.2em 0.4em would look better visually, it's what GitHub does too (They do it through a unicode space in :before and :after) to make the left and right padding slightly larger.
jasnell
commented
Oct 29, 2015
Member
LGTM |
phillipjforce-pushed
the
doc-code-visibility
branch
from
October 29, 2015 21:22
cca141e to
ef2e668Comparephillipj
commented
Oct 29, 2015
MemberAuthor
@silverwind agreed, just updated with a little extra horizontal padding.
|
silverwind
commented
Oct 29, 2015
Contributor
LGTM One thing that bugs me a bit is that |
silverwind pushed a commit
that referenced
this pull request
Oct 29, 2015
This makes the code spans in the API docs more visible and therefore readable by adding some background color. PR-URL: #3573 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
silverwind
commented
Oct 29, 2015
Contributor
Thanks. Landed in d995b72. |
phillipj
commented
Nov 4, 2015
MemberAuthor
Any chance this could be backported to |
jasnell
commented
Nov 4, 2015
Member
There shouldn't be any problem getting this in to v4 :-) |
rvagg pushed a commit
that referenced
this pull request
Nov 7, 2015
This makes the code spans in the API docs more visible and therefore readable by adding some background color. PR-URL: #3573 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Nov 16, 2015
This makes the code spans in the API docs more visible and therefore readable by adding some background color. PR-URL: #3573 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
commented
Nov 16, 2015
Contributor
landed in lts-v4.x-staging as 08ab9f3 |
MylesBorins
commented
Nov 16, 2015
Contributor
@silverwind does this need a land-on-v5.x tag if it is on master? |
silverwind
commented
Nov 16, 2015
Contributor
@thealphanerd No, that tag was unnecessary ;) |
MylesBorins
commented
Nov 16, 2015
Contributor
phillipj
commented
Nov 17, 2015
MemberAuthor
Thanks @thealphanerd! |
rvagg pushed a commit
that referenced
this pull request
Dec 4, 2015
This makes the code spans in the API docs more visible and therefore readable by adding some background color. PR-URL: #3573 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Closed
jasnell pushed a commit
that referenced
this pull request
Dec 17, 2015
This makes the code spans in the API docs more visible and therefore readable by adding some background color. PR-URL: #3573 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
jasnell pushed a commit
that referenced
this pull request
Dec 23, 2015
This makes the code spans in the API docs more visible and therefore readable by adding some background color. PR-URL: #3573 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the code spans in the API docs alot more visible and therefore readable by adding some background color. Its more or less what github.com does, and what we decided to do on nodejs.org with nodejs/nodejs.org#146.
Closes an issue raised about API docs readability in nodejs/nodejs.org#121.