Uh oh!
There was an error while loading. Please reload this page.
console: use more primordials - #35734
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
aduh95
commented
Oct 21, 2020
ContributorAuthor
Why am I getting |
targos
commented
Oct 21, 2020
Member
My guess is that the method is not available to primordials because it can be disabled in V8 with |
This comment has been minimized.
This comment has been minimized.
aduh95
commented
Oct 21, 2020
ContributorAuthor
Interesting. Well I guess we'll have to refrain from using it in node core for the time being then… |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
Oct 28, 2020
Collaborator
aduh95
commented
Oct 29, 2020
ContributorAuthor
@nodejs/console Can you review this please? |
aduh95force-pushed
the
console-refactor-primordials
branch
from
October 31, 2020 18:57
446aa98 to
f2c9f81Comparenodejs-github-bot
commented
Nov 1, 2020
Collaborator
PR-URL: nodejs#35734 Reviewed-By: Rich Trott <rtrott@gmail.com>
aduh95force-pushed
the
console-refactor-primordials
branch
from
November 5, 2020 22:12
f2c9f81 to
1f6ca18Compareaduh95
commented
Nov 5, 2020
ContributorAuthor
Landed in 1f6ca18 |
danielleadams pushed a commit
that referenced
this pull request
Nov 9, 2020
PR-URL: #35734 Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Dec 9, 2020
PR-URL: #35734 Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Dec 10, 2020
PR-URL: #35734 Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Dec 15, 2020
PR-URL: #35734 Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport requested because optional chaining is not available on Node.js 12.No need for optional chaining after all 😅Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes