Uh oh!
There was an error while loading. Please reload this page.
deps: update to cjs-module-lexer@0.4.3 - #35745
Closed
guybedford wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
Oct 21, 2020
Collaborator
Review requested:
|
codecov-io
commented
Oct 21, 2020
Codecov Report
@@ Coverage Diff @@## master #35745 +/- ##
==========================================
- Coverage 96.41% 96.40% -0.02%
==========================================
Files 223 223 Lines 73685 73685 ==========================================
- Hits 71043 71035 -8 - Misses 2642 2650 +8
Continue to review full report at Codecov.
|
21 tasks
hybrist
approved these changes
Oct 21, 2020
ryzokuken
approved these changes
Oct 22, 2020
nodejs-github-bot
commented
Oct 22, 2020
Collaborator
nodejs-github-bot
commented
Oct 24, 2020
Collaborator
guybedford
commented
Oct 24, 2020
ContributorAuthor
All tests passing on the build except for one ARM run. Running a final time... |
nodejs-github-bot
commented
Oct 24, 2020
Collaborator
guybedford added a commit
that referenced
this pull request
Oct 24, 2020
PR-URL: #35745 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
guybedford
commented
Oct 24, 2020
ContributorAuthor
The same CI seems to be consistently failing across builds today, so this seems most certainly unrelated. Landed in fdaf9cb. |
targos pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35745 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
MylesBorins pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35745 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
MylesBorins pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35745 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Nov 16, 2020
PR-URL: #35745 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
MylesBorins pushed a commit
that referenced
this pull request
Nov 16, 2020
PR-URL: #35745 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CHANGELOG.md includes the listed features which are supported including:
These are all extensions to the functionality so this is entirely non-breaking, with associated test coverage in the PRs.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes