Uh oh!
There was an error while loading. Please reload this page.
src: remove ignore GCC -Wcast-function-type for v8 - #35768
Closed
danbev wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
Oct 23, 2020
Collaborator
2 tasks
codecov-io
commented
Oct 23, 2020
Codecov Report
@@ Coverage Diff @@## master #35768 +/- ##
==========================================
- Coverage 96.40% 87.90% -8.50%
==========================================
Files 223 477 +254 Lines 73685 113090 +39405 Branches 0 24627 +24627 ==========================================
+ Hits 71038 99417 +28379 - Misses 2647 7962 +5315 - Partials 0 5711 +5711
|
targos
approved these changes
Oct 23, 2020
Trott
approved these changes
Oct 23, 2020
Trott
left a comment
Member
There was a problem hiding this comment.
LGTM. Might be worth double-checking the commit message text to make sure it's what you intended.
This reverts Commit 3ff2aec ("src: ignore GCC -Wcast-function-type for v8.h") and Commit 2462a2c ("src: fix ignore GCC -Wcast-function-type for older compilers") as this has now been included in the V8 version being used. Refs: v8/v8@f08cbfd
danbevforce-pushed
the
remove-gcc-cast-function-type2
branch
from
October 23, 2020 13:22
f2f788f to
3ae98acComparedanbev
commented
Oct 23, 2020
ContributorAuthor
Thanks for pointing that out, it was not very clear. |
JungMinu
approved these changes
Oct 25, 2020
devnexen
approved these changes
Oct 26, 2020
nodejs-github-bot
commented
Oct 26, 2020
Collaborator
ContributorAuthor
Re-run of failing /node-test-commit-linux-containered ✔️ |
danbev added a commit
that referenced
this pull request
Oct 26, 2020
This reverts Commit 3ff2aec ("src: ignore GCC -Wcast-function-type for v8.h") and Commit 2462a2c ("src: fix ignore GCC -Wcast-function-type for older compilers") as this has now been included in the V8 version being used. PR-URL: #35768 Refs: v8/v8@f08cbfd Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
danbev
commented
Oct 26, 2020
ContributorAuthor
Landed in 9ff25b1. |
targos pushed a commit
that referenced
this pull request
Nov 3, 2020
This reverts Commit 3ff2aec ("src: ignore GCC -Wcast-function-type for v8.h") and Commit 2462a2c ("src: fix ignore GCC -Wcast-function-type for older compilers") as this has now been included in the V8 version being used. PR-URL: #35768 Refs: v8/v8@f08cbfd Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts Commit 3ff2aec ("src: ignore GCC -Wcast-function-type for v8.h") and Commit
2462a2c ("src: fix ignore GCC -Wcast-function-type for older compilers") as this has
now been included in the V8 version being used.
Refs:
v8/v8@f08cbfd
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes