Uh oh!
There was an error while loading. Please reload this page.
module: remove unnecessary JSON.stringify - #3578
Closed
zertosh wants to merge 1 commit into
Closed
Conversation
MylesBorins
commented
Oct 29, 2015
Contributor
could template strings have a similar result? |
cjihrig
commented
Oct 29, 2015
Contributor
LGTM. It's simpler to read too. I think template strings would suffer the same problem as the original code (stringification even when not debugging). |
zertosh
commented
Oct 29, 2015
ContributorAuthor
For the |
Contributor
There was a problem hiding this comment.
Style nit: this should align with the previous line's parameter
`debuglog` uses `%j` as a placeholder for replacement with `JSON.stringify`. So that `JSON.stringify` is only called when the appropriate debug flag is on. The other `%s` changes are for style consistency.
thefourtheye
commented
Oct 29, 2015
Contributor
LGTM with a style nit |
evanlucas
commented
Oct 29, 2015
Contributor
LGTM |
jasnell
commented
Oct 29, 2015
Member
LGTM but since this touches module we may want more @nodejs/ctc review. |
trevnorris
commented
Oct 29, 2015
Contributor
I generally hate how we handle |
zertosh
commented
Oct 31, 2015
ContributorAuthor
Seems like everyone is Ok on this. Merge? |
evanlucas
commented
Nov 5, 2015
Contributor
@jasnell am I good to land this or do we want to get CTC review? |
cjihrig
commented
Nov 5, 2015
Contributor
I think 3 CTC LGTMs and 2 more from collaborators should be sufficient. |
cjihrig
commented
Nov 5, 2015
Contributor
Although, has CI been run? |
evanlucas
commented
Nov 5, 2015
Contributor
Good catch. CI: https://ci.nodejs.org/job/node-test-pull-request/674/ |
jasnell
commented
Nov 5, 2015
Member
+1 :)
|
jasnell pushed a commit
that referenced
this pull request
Nov 5, 2015
`debuglog` uses `%j` as a placeholder for replacement with `JSON.stringify`. So that `JSON.stringify` is only called when the appropriate debug flag is on. The other `%s` changes are for style consistency. PR-URL: #3578 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
commented
Nov 5, 2015
Member
CI was green. Landed in faa3bb8 |
rvagg pushed a commit
that referenced
this pull request
Nov 7, 2015
`debuglog` uses `%j` as a placeholder for replacement with `JSON.stringify`. So that `JSON.stringify` is only called when the appropriate debug flag is on. The other `%s` changes are for style consistency. PR-URL: #3578 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Nov 16, 2015
`debuglog` uses `%j` as a placeholder for replacement with `JSON.stringify`. So that `JSON.stringify` is only called when the appropriate debug flag is on. The other `%s` changes are for style consistency. PR-URL: #3578 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
commented
Nov 16, 2015
Contributor
landed in lts-v4.x-staging as 948af71 |
rvagg pushed a commit
that referenced
this pull request
Dec 4, 2015
`debuglog` uses `%j` as a placeholder for replacement with `JSON.stringify`. So that `JSON.stringify` is only called when the appropriate debug flag is on. The other `%s` changes are for style consistency. PR-URL: #3578 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Closed
jasnell pushed a commit
that referenced
this pull request
Dec 17, 2015
`debuglog` uses `%j` as a placeholder for replacement with `JSON.stringify`. So that `JSON.stringify` is only called when the appropriate debug flag is on. The other `%s` changes are for style consistency. PR-URL: #3578 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell pushed a commit
that referenced
this pull request
Dec 23, 2015
`debuglog` uses `%j` as a placeholder for replacement with `JSON.stringify`. So that `JSON.stringify` is only called when the appropriate debug flag is on. The other `%s` changes are for style consistency. PR-URL: #3578 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
debulog's placeholder replacement%jfor stringification. So calls toJSON.stringifyare only made bydebuglogwhen you're actually debugging. Also, made the remaining calls todebuglogconsistent with this style.