Skip to content

doc: fix _construct example params order - #35790

Closed
a0viedo wants to merge 1 commit into
nodejs:masterfrom
a0viedo:patch-1
Closed

doc: fix _construct example params order#35790
a0viedo wants to merge 1 commit into
nodejs:masterfrom
a0viedo:patch-1

Conversation

@a0viedo

@a0viedoa0viedo commented Oct 24, 2020

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

cc @nodejs/documentation

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Oct 24, 2020
juanarbol
juanarbol approved these changes Oct 26, 2020
View reviewed changes

@juanarboljuanarbol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2020
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2020
@github-actions

github-actionsBot commented Oct 27, 2020

Copy link
Copy Markdown
Contributor

Landed in 8f1e4d3...7c3ce9d

nodejs-github-bot pushed a commit that referenced this pull request Oct 27, 2020
@a0viedo@nodejs-github-bot
doc: fix _construct example params order
7c3ce9d
PR-URL: #35790
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Nov 3, 2020
@a0viedo@targos
doc: fix _construct example params order
c2e6a4b
PR-URL: #35790
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Nov 3, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkelfhinkelfhinkel approved these changes
@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@watildewatildewatilde approved these changes
@ronagronagronag approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@juanarboljuanarboljuanarbol approved these changes

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12 participants

@a0viedo@fhinkel@jasnell@Trott@addaleax@lpinca@watilde@ronag@gireeshpunathil@juanarbol@BethGriggs@nodejs-github-bot