Skip to content

deps: update acorn to v8.0.4 - #35791

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:update-acorn
Closed

deps: update acorn to v8.0.4#35791
targos wants to merge 1 commit into
nodejs:masterfrom
targos:update-acorn

Conversation

@targos

@targostargos commented Oct 24, 2020

Copy link
Copy Markdown
Member

This adds support for nullish coalescing, optional chaining and
numeric separators.
The acorn-numeric-separator plugin can be removed.

@targos
deps: update acorn to v8.0.4
7338e39
This adds support for nullish coalescing, optional chaining and
numeric separators.
The acorn-numeric-separator plugin can be removed.
@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/community-committee
  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Oct 24, 2020
@targostargos added request-ci Add this label to start a Jenkins CI on a PR. and removed lib / src Issues and PRs related to general changes in the lib or src directory. labels Oct 24, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2020
@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33846/

Trott
Trott reviewed Oct 24, 2020
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@targostargos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 25, 2020
mcollina
mcollina approved these changes Oct 25, 2020
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jasnell
jasnell approved these changes Oct 26, 2020
View reviewed changes

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 🎉 🥳 🎉 🥳 🎉

@jasnell

jasnell commented Oct 26, 2020

Copy link
Copy Markdown
Member

Do you know if it also supports the new logical operators? e.g. ??= and !!= etc

@targos

targos commented Oct 26, 2020

Copy link
Copy Markdown
MemberAuthor

@jasnell I think they are supported, but only with ecmaVersion: 2021. I would suggest to enable it in a separate PR so this one can be cherry-picked to v14.

bnb
bnb approved these changes Oct 26, 2020
View reviewed changes

@bnbbnb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from the CommComm perspective since it's requested by the bot. Cursory glance at the markdown content + License changes, plus an RSLGTM on code since a lot of folks I trust to do the work there have approved.

@gengjiawengengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2020
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2020
@github-actions

github-actionsBot commented Oct 27, 2020

Copy link
Copy Markdown
Contributor

Landed in ed5e539...16b2bc0

nodejs-github-bot pushed a commit that referenced this pull request Oct 27, 2020
@targos@nodejs-github-bot
deps: update acorn to v8.0.4
16b2bc0
This adds support for nullish coalescing, optional chaining and
numeric separators.
The acorn-numeric-separator plugin can be removed.
PR-URL: #35791
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@targos
targos deleted the update-acorn branch October 27, 2020 05:35
@richardlaurichardlau mentioned this pull request Oct 27, 2020
Closed
targos added a commit that referenced this pull request Nov 3, 2020
@targos
deps: update acorn to v8.0.4
52a77db
This adds support for nullish coalescing, optional chaining and
numeric separators.
The acorn-numeric-separator plugin can be removed.
PR-URL: #35791
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@targostargos mentioned this pull request Nov 3, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@targos@BethGriggs
deps: update acorn to v8.0.4
bfd30cc
This adds support for nullish coalescing, optional chaining and
numeric separators.
The acorn-numeric-separator plugin can be removed.
PR-URL: #35791
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@targos@BethGriggs
deps: update acorn to v8.0.4
dc5fdb8
This adds support for nullish coalescing, optional chaining and
numeric separators.
The acorn-numeric-separator plugin can be removed.
PR-URL: #35791
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs added a commit that referenced this pull request Dec 15, 2020
@BethGriggs
2020-12-15, Version 14.15.2 'Fermium' (LTS)
2b6dd9c
Notable Changes:
- **deps**:
- upgrade npm to 6.14.9 (Myles Borins)
#36450
- update acorn to v8.0.4 (Michaël Zasso)
#35791
- **doc**: add release key for Danielle Adams (Danielle Adams)
#35545
- **http2**: check write not scheduled in scope destructor (David Halls)
#36241
- **stream**: fix regression on duplex end (Momtchil Momtchev)
#35941
PR-URL: #36476
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@targos@BethGriggs
deps: update acorn to v8.0.4
7367e6c
This adds support for nullish coalescing, optional chaining and
numeric separators.
The acorn-numeric-separator plugin can be removed.
PR-URL: #35791
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
BethGriggs added a commit that referenced this pull request Dec 15, 2020
@BethGriggs
2020-12-15, Version 14.15.2 'Fermium' (LTS)
a2f9a70
Notable Changes:
- **deps**:
- upgrade npm to 6.14.9 (Myles Borins)
#36450
- update acorn to v8.0.4 (Michaël Zasso)
#35791
- **doc**: add release key for Danielle Adams (Danielle Adams)
#35545
- **http2**: check write not scheduled in scope destructor (David Halls)
#36241
- **stream**: fix regression on duplex end (Momtchil Momtchev)
#35941
PR-URL: #36476
BethGriggs added a commit that referenced this pull request Dec 15, 2020
@BethGriggs
2020-12-15, Version 14.15.2 'Fermium' (LTS)
a150926
Notable Changes:
- **deps**:
- upgrade npm to 6.14.9 (Myles Borins)
#36450
- update acorn to v8.0.4 (Michaël Zasso)
#35791
- **doc**: add release key for Danielle Adams (Danielle Adams)
#35545
- **http2**: check write not scheduled in scope destructor (David Halls)
#36241
- **stream**: fix regression on duplex end (Momtchil Momtchev)
#35941
PR-URL: #36476
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@jasnelljasnelljasnell approved these changes
@bnbbnbbnb approved these changes
@TrottTrottTrott approved these changes
@watildewatildewatilde approved these changes
@codebyterecodebyterecodebytere approved these changes
@cjihrigcjihrigcjihrig approved these changes
@gengjiawengengjiawengengjiawen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@targos@nodejs-github-bot@jasnell@mcollina@bnb@Trott@watilde@codebytere@cjihrig@gengjiawen