Skip to content

doc: fix typo in BUILDING.md - #35807

Closed
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:doc/fix-typo-in-BUILDING.md
Closed

doc: fix typo in BUILDING.md#35807
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:doc/fix-typo-in-BUILDING.md

Conversation

@RaisinTen

@RaisinTenRaisinTen commented Oct 26, 2020

Copy link
Copy Markdown
Member
Checklist

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Oct 26, 2020
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 26, 2020
@RaisinTen

RaisinTen commented Oct 26, 2020

Copy link
Copy Markdown
MemberAuthor

How may I fix this?

@watilde

watilde commented Oct 26, 2020

Copy link
Copy Markdown
Member

As this PR fixes a typo, let me ask for 👍 to fast track.

@RaisinTen Basically we need to wait for 48h before we ship or get more than two 👍 from collaborators on this comment to quickly ship. Refs: https://github.com/nodejs/node/blob/master/doc/guides/collaborator-guide.md#waiting-for-approvals

@watildewatilde added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 26, 2020
@aduh95

aduh95 commented Oct 26, 2020

Copy link
Copy Markdown
Contributor

How may I fix this?

@RaisinTen If you refer to the failing GitHub Action, don't worry it's just a flaky CI job that timed out. I've restarted the job, it should be fine now.

@RaisinTen

RaisinTen commented Oct 26, 2020

Copy link
Copy Markdown
MemberAuthor

@watilde@aduh95 thanks for the clarification and the re-run 🙂

juanarbol
juanarbol approved these changes Oct 26, 2020
View reviewed changes

@juanarboljuanarbol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaisinTen Thanks for your contribution. This is awesome!

@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2020
@nodejs-github-bot

nodejs-github-bot commented Oct 26, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33871/

@juanarbol

juanarbol commented Oct 26, 2020

Copy link
Copy Markdown
Member

@lpinca This is a doc-only change, this does not require a full CI-job, with green actions is enough. I think this can be landed as it is now (?).

@watildewatilde added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2020
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2020
@github-actions

github-actionsBot commented Oct 27, 2020

Copy link
Copy Markdown
Contributor

Landed in 9ff25b1...ed5e539

nodejs-github-bot pushed a commit that referenced this pull request Oct 27, 2020
@RaisinTen@nodejs-github-bot
doc: fix typo in BUILDING.md
ed5e539
PR-URL: #35807
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 3, 2020
@RaisinTen@targos
doc: fix typo in BUILDING.md
c365867
PR-URL: #35807
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request Nov 3, 2020
Merged
@RaisinTen
RaisinTen deleted the doc/fix-typo-in-BUILDING.md branch November 10, 2020 07:10
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@RaisinTen@BethGriggs
doc: fix typo in BUILDING.md
384d518
PR-URL: #35807
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@RaisinTen@BethGriggs
doc: fix typo in BUILDING.md
956fdc7
PR-URL: #35807
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 10, 2020
Merged
targos pushed a commit that referenced this pull request Mar 3, 2021
@RaisinTen@targos
doc: fix typo in BUILDING.md
772afde
PR-URL: #35807
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 6, 2021
@RaisinTen@MylesBorins
doc: fix typo in BUILDING.md
d1004d2
PR-URL: #35807
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@watildewatildewatilde approved these changes
@gengjiawengengjiawengengjiawen approved these changes
@richardlaurichardlaurichardlau approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@aduh95aduh95aduh95 approved these changes
@juanarboljuanarboljuanarbol approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@RaisinTen@watilde@aduh95@nodejs-github-bot@juanarbol@Trott@lpinca@gengjiawen@richardlau@gireeshpunathil