Uh oh!
There was an error while loading. Please reload this page.
benchmark: add startup benchmark for loading public modules - #35816
Closed
joyeecheung wants to merge 1 commit into
Closed
benchmark: add startup benchmark for loading public modules#35816joyeecheung wants to merge 1 commit into
joyeecheung wants to merge 1 commit into
Conversation
Adding a new benchmark for testing the performance of loading available public modules.
nodejs-github-bot
commented
Oct 26, 2020
Collaborator
Review requested:
|
jasnell
approved these changes
Oct 26, 2020
Trott
approved these changes
Oct 28, 2020
nodejs-github-bot
commented
Oct 28, 2020
Collaborator
ZYSzys
reviewed
Oct 29, 2020
| 'util', | ||
| 'vm', | ||
| 'zlib', | ||
| ]; |
Member
There was a problem hiding this comment.
Hardcode was likely missed some modules, just like v8, worker_threads here.
Can we directly use require('module').builtinModules ?
MemberAuthor
There was a problem hiding this comment.
@ZYSzys That way we may not be able to get fair results on different versions of Node.js (some of them may have more modules)
nodejs-github-bot
commented
Oct 30, 2020
Collaborator
joyeecheung added a commit
that referenced
this pull request
Nov 4, 2020
Adding a new benchmark for testing the performance of loading available public modules. PR-URL: #35816 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
joyeecheung
commented
Nov 4, 2020
MemberAuthor
Landed in 38c1569, thanks! |
targos pushed a commit
that referenced
this pull request
Nov 4, 2020
Adding a new benchmark for testing the performance of loading available public modules. PR-URL: #35816 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau added a commit
to richardlau/node-1
that referenced
this pull request
Nov 4, 2020
`inspector` and `trace_events` will throw errors if Node.js has been compiled with `--without-intl`. Refs: nodejs#35816
This was referenced Nov 4, 2020
nodejs-github-bot pushed a commit
that referenced
this pull request
Nov 5, 2020
`inspector` and `trace_events` will throw errors if Node.js has been compiled with `--without-intl`. Refs: #35816 PR-URL: #35968Fixes: #35962 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
richardlau
commented
Nov 5, 2020
Member
If backported, this should land with #35968. |
danielleadams pushed a commit
that referenced
this pull request
Nov 9, 2020
`inspector` and `trace_events` will throw errors if Node.js has been compiled with `--without-intl`. Refs: #35816 PR-URL: #35968Fixes: #35962 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
BethGriggs pushed a commit
that referenced
this pull request
Dec 8, 2020
Adding a new benchmark for testing the performance of loading available public modules. PR-URL: #35816 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Dec 9, 2020
`inspector` and `trace_events` will throw errors if Node.js has been compiled with `--without-intl`. Refs: #35816 PR-URL: #35968Fixes: #35962 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
BethGriggs pushed a commit
that referenced
this pull request
Dec 10, 2020
Adding a new benchmark for testing the performance of loading available public modules. PR-URL: #35816 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Dec 10, 2020
`inspector` and `trace_events` will throw errors if Node.js has been compiled with `--without-intl`. Refs: #35816 PR-URL: #35968Fixes: #35962 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Dec 15, 2020
Adding a new benchmark for testing the performance of loading available public modules. PR-URL: #35816 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Dec 15, 2020
`inspector` and `trace_events` will throw errors if Node.js has been compiled with `--without-intl`. Refs: #35816 PR-URL: #35968Fixes: #35962 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a new benchmark for testing the performance of loading
available public modules.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes