Skip to content

benchmark: make the benchmark tool work with Node 10 - #35817

Closed
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:bench-compat
Closed

benchmark: make the benchmark tool work with Node 10#35817
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:bench-compat

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented Oct 26, 2020

Copy link
Copy Markdown
Member

Avoid using class fields in the benchmark tools since they are
not available in Node 10. This can be reverted when Node 10
reaches EOL.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@joyeecheung
benchmark: make the benchmark tool work with Node 10
49f7a48
Avoid using class fields in the benchmark tools since they are
not available in Node 10. This can be reverted when Node 10
reaches EOL.
@nodejs-github-botnodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Oct 26, 2020
lpinca
lpinca reviewed Oct 27, 2020
View reviewed changes
Comment threadbenchmark/common.js
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2020
@nodejs-github-bot

nodejs-github-bot commented Oct 30, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33969/

mhdawson
mhdawson approved these changes Oct 30, 2020
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2020
@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33987/

@mhdawsonmhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2020
@nodejs-github-bot

nodejs-github-bot commented Nov 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34025/

mmarchini
mmarchini approved these changes Nov 3, 2020
View reviewed changes

@mmarchinimmarchini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any way we can test/lint for valid syntax for Node.js v10?

@richardlau

richardlau commented Nov 3, 2020

Copy link
Copy Markdown
Member

any way we can test/lint for valid syntax for Node.js v10?

Run the lint action with Node.js 10?

joyeecheung added a commit that referenced this pull request Nov 4, 2020
@joyeecheung
benchmark: make the benchmark tool work with Node 10
dbcadf0
Avoid using class fields in the benchmark tools since they are
not available in Node 10. This can be reverted when Node 10
reaches EOL.
PR-URL: #35817
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
@joyeecheung

joyeecheung commented Nov 4, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in dbcadf0, thanks!

targos pushed a commit that referenced this pull request Nov 4, 2020
@joyeecheung@targos
benchmark: make the benchmark tool work with Node 10
76ebae4
Avoid using class fields in the benchmark tools since they are
not available in Node 10. This can be reverted when Node 10
reaches EOL.
PR-URL: #35817
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
@targostargos mentioned this pull request Nov 4, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@joyeecheung@BethGriggs
benchmark: make the benchmark tool work with Node 10
5db0b07
Avoid using class fields in the benchmark tools since they are
not available in Node 10. This can be reverted when Node 10
reaches EOL.
PR-URL: #35817
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@joyeecheung@BethGriggs
benchmark: make the benchmark tool work with Node 10
c062d0b
Avoid using class fields in the benchmark tools since they are
not available in Node 10. This can be reverted when Node 10
reaches EOL.
PR-URL: #35817
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
@BethGriggsBethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@joyeecheung@BethGriggs
benchmark: make the benchmark tool work with Node 10
f648796
Avoid using class fields in the benchmark tools since they are
not available in Node 10. This can be reverted when Node 10
reaches EOL.
PR-URL: #35817
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@TrottTrottTrott approved these changes
@watildewatildewatilde approved these changes
@gengjiawengengjiawengengjiawen approved these changes
@ZYSzysZYSzysZYSzys approved these changes
+2 more reviewers
@mmarchinimmarchinimmarchini approved these changes
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

benchmarkIssues and PRs related to the benchmark subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@joyeecheung@nodejs-github-bot@richardlau@Trott@lpinca@watilde@gengjiawen@mmarchini@mhdawson@ZYSzys