Uh oh!
There was an error while loading. Please reload this page.
docs: add example for setBreakpoint() with a conditional statement - #35823
Merged
Conversation
Trott
reviewed
Oct 27, 2020
Uh oh!
There was an error while loading. Please reload this page.
Trott
commented
Oct 27, 2020
Member
Welcome @copperwall and thanks for the pull request! I left a suggestion, but it's totally optional. Looks good to me either way. |
Trott
approved these changes
Oct 27, 2020
hybrist
approved these changes
Oct 27, 2020
hybrist
left a comment
Contributor
There was a problem hiding this comment.
LGTM, potentially with Trott's suggestion.
Trott
approved these changes
Oct 29, 2020
Trott
commented
Oct 29, 2020
Member
Landed in a3cc239 |
Trott
commented
Oct 29, 2020
Member
Thanks for the contribution! 🎉 |
targos pushed a commit
that referenced
this pull request
Nov 3, 2020
The `node-inspect` debugging client supports passing an optional third parameter as a string to be evaluated when the breakpoint is hit. If the condition evaluates to `true` in the current context, the breakpoint pauses execution; otherwise the execution continues. This was raised as an issue in nodejs/node-inspect#68, but the client already supports that functionality, so I thought it'd be helpful to add it to the node documentation. PR-URL: #35823 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Dec 8, 2020
The `node-inspect` debugging client supports passing an optional third parameter as a string to be evaluated when the breakpoint is hit. If the condition evaluates to `true` in the current context, the breakpoint pauses execution; otherwise the execution continues. This was raised as an issue in nodejs/node-inspect#68, but the client already supports that functionality, so I thought it'd be helpful to add it to the node documentation. PR-URL: #35823 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Dec 10, 2020
The `node-inspect` debugging client supports passing an optional third parameter as a string to be evaluated when the breakpoint is hit. If the condition evaluates to `true` in the current context, the breakpoint pauses execution; otherwise the execution continues. This was raised as an issue in nodejs/node-inspect#68, but the client already supports that functionality, so I thought it'd be helpful to add it to the node documentation. PR-URL: #35823 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Dec 15, 2020
The `node-inspect` debugging client supports passing an optional third parameter as a string to be evaluated when the breakpoint is hit. If the condition evaluates to `true` in the current context, the breakpoint pauses execution; otherwise the execution continues. This was raised as an issue in nodejs/node-inspect#68, but the client already supports that functionality, so I thought it'd be helpful to add it to the node documentation. PR-URL: #35823 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
node-inspectdebugging client supports passing an optional third parameter as a string to be evaluated when the breakpoint is hit. If the condition evaluates totruein the current context, the breakpoint pauses execution, otherwise the execution continues.This was raised as an issue in nodejs/node-inspect#68, but the client already supports that functionality, so I thought it'd be helpful to add it to the node documentation.
Checklist