Skip to content

zlib: test BrotliCompress throws invalid arg value - #35830

Closed
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:test-zlib-invalid-arg-value-brotlicompress
Closed

zlib: test BrotliCompress throws invalid arg value#35830
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:test-zlib-invalid-arg-value-brotlicompress

Conversation

@RaisinTen

@RaisinTenRaisinTen commented Oct 27, 2020

Copy link
Copy Markdown
Member

Improving the coverage for this:

node/lib/zlib.js

Lines 807 to 809 in 0ca8617

thrownewERR_INVALID_ARG_TYPE('options.params[key]',
'number',opts.params[origKey]);
}

First time I'm writing a test! 😃

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Oct 27, 2020
@aduh95aduh95 added the brotli Issues and PRs related to the brotli dependency. label Oct 27, 2020
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2020
@nodejs-github-bot

nodejs-github-bot commented Oct 27, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33888/

lpinca
lpinca approved these changes Oct 28, 2020
View reviewed changes
Comment threadtest/parallel/test-zlib-invalid-arg-value-brotli-compress.js Outdated
Comment threadtest/parallel/test-zlib-invalid-arg-value-brotli-compress.js Outdated
@RaisinTen

RaisinTen commented Oct 28, 2020•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@lpinca since these commits are all related, do you think I should squash them?

@lpinca

lpinca commented Oct 28, 2020

Copy link
Copy Markdown
Member

Yes, please do it. Thank you.

@RaisinTen
RaisinTenforce-pushed the test-zlib-invalid-arg-value-brotlicompress branch from 122b8f1 to a9ce812CompareOctober 28, 2020 12:31
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@rickyesrickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2020
@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33984/

@lpinca

lpinca commented Oct 31, 2020

Copy link
Copy Markdown
Member

Landed in c0af8bd.

lpinca pushed a commit that referenced this pull request Oct 31, 2020
@RaisinTen@lpinca
zlib: test BrotliCompress throws invalid arg value
c0af8bd
PR-URL: #35830
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@lpincalpinca closed this Oct 31, 2020
@RaisinTen
RaisinTen deleted the test-zlib-invalid-arg-value-brotlicompress branch October 31, 2020 05:49
targos pushed a commit that referenced this pull request Nov 3, 2020
@RaisinTen@targos
zlib: test BrotliCompress throws invalid arg value
102d7df
PR-URL: #35830
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@targostargos mentioned this pull request Nov 3, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@RaisinTen@BethGriggs
zlib: test BrotliCompress throws invalid arg value
0ea3a91
PR-URL: #35830
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@RaisinTen@BethGriggs
zlib: test BrotliCompress throws invalid arg value
0d80a93
PR-URL: #35830
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@RaisinTen@BethGriggs
zlib: test BrotliCompress throws invalid arg value
f59e225
PR-URL: #35830
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
This was referenced May 22, 2023
Open
Open
Open
@137717unity137717unity mentioned this pull request May 22, 2023
Open
@snyk-botsnyk-bot mentioned this pull request May 23, 2023
Open
@wedataintelligencewedataintelligence mentioned this pull request May 24, 2023
Open
@baby636baby636 mentioned this pull request May 24, 2023
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Nov 25, 2023
Open
@wedataintelligencewedataintelligence mentioned this pull request Nov 28, 2023
Open
@baby636baby636 mentioned this pull request Nov 28, 2023
Open
@ron-a20ron-a20 mentioned this pull request Dec 19, 2023
Open
@137717unity137717unity mentioned this pull request Dec 19, 2023
Open
@wedataintelligencewedataintelligence mentioned this pull request Dec 19, 2023
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Dec 19, 2023
Open
@baby636baby636 mentioned this pull request Dec 20, 2023
Open
@137717unity137717unity mentioned this pull request Apr 14, 2024
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Apr 14, 2024
Open
@ron-a20ron-a20 mentioned this pull request Apr 14, 2024
Open
@molllyn1molllyn1 mentioned this pull request Apr 14, 2024
Open
@kissofirekissofire mentioned this pull request Apr 14, 2024
Open
@wedataintelligencewedataintelligence mentioned this pull request Apr 14, 2024
Open
@baby636baby636 mentioned this pull request Apr 15, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@TrottTrottTrott approved these changes
+1 more reviewer
@rickyesrickyesrickyes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

brotliIssues and PRs related to the brotli dependency.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@RaisinTen@nodejs-github-bot@lpinca@Trott@rickyes@aduh95