Uh oh!
There was an error while loading. Please reload this page.
test: add test to fs/promises setImmediate - #35852
Merged
Trott merged 1 commit intoOct 31, 2020
Merged
Conversation
yosuke-furukawa
self-requested a review
October 28, 2020 14:45
yosuke-furukawa
approved these changes
Oct 28, 2020
shisama
approved these changes
Oct 28, 2020
benjamingr
approved these changes
Oct 28, 2020
nodejs-github-bot
commented
Oct 28, 2020
Collaborator
Leko
approved these changes
Oct 28, 2020
watilde
approved these changes
Oct 28, 2020
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
Oct 29, 2020
Collaborator
Trott
approved these changes
Oct 29, 2020
3 tasks
Collaborator
Add test pattern to setImmediate when ref's type is not boolean PR-URL: nodejs#35852 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trottforce-pushed
the
coverage/test-timers-promisifiled
branch
from
October 31, 2020 11:48
b08259a to
5dd344aCompareTrott
commented
Oct 31, 2020
Member
Landed in 5dd344a |
Trott
commented
Oct 31, 2020
Member
Thanks for the contribution! 🎉 |
targos pushed a commit
that referenced
this pull request
Nov 3, 2020
Add test pattern to setImmediate when ref's type is not boolean PR-URL: #35852 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test pattern to setImmediate when ref's type is not boolean
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes