Uh oh!
There was an error while loading. Please reload this page.
src: remove ERR prefix in crypto status enums - #35867
Closed
danbev wants to merge 1 commit into
Closed
Conversation
This commit removes the ERR prefix of the remaining status enums in crypto so they are consistent with Commit 923f76d ("src: remove ERR prefix in WebCryptoKeyExportStatus").
nodejs-github-bot
commented
Oct 29, 2020
Collaborator
Review requested:
|
nodejs-github-bot
commented
Oct 29, 2020
Collaborator
Trott
approved these changes
Oct 29, 2020
cjihrig
approved these changes
Oct 29, 2020
tniessen
approved these changes
Nov 1, 2020
devnexen
approved these changes
Nov 1, 2020
fhinkel
approved these changes
Nov 2, 2020
nodejs-github-bot
commented
Nov 4, 2020
Collaborator
danbev added a commit
that referenced
this pull request
Nov 5, 2020
This commit removes the ERR prefix of the remaining status enums in crypto so they are consistent with Commit 923f76d ("src: remove ERR prefix in WebCryptoKeyExportStatus"). PR-URL: #35867 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
danbev
commented
Nov 5, 2020
ContributorAuthor
Landed in 1387f4b. |
danielleadams pushed a commit
that referenced
this pull request
Nov 9, 2020
This commit removes the ERR prefix of the remaining status enums in crypto so they are consistent with Commit 923f76d ("src: remove ERR prefix in WebCryptoKeyExportStatus"). PR-URL: #35867 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the ERR prefix of the remaining status enums in
crypto so they are consistent with Commit 923f76d
("src: remove ERR prefix in WebCryptoKeyExportStatus").
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes