Uh oh!
There was an error while loading. Please reload this page.
domain: refactor to use more primordials - #35885
Closed
aduh95 wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
Oct 31, 2020
Collaborator
aduh95
commented
Nov 2, 2020
ContributorAuthor
@nodejs/domains can you review this please? |
Trott
approved these changes
Nov 6, 2020
Contributor
Landed in 8fa9035...0ad4f70 |
nodejs-github-bot pushed a commit
that referenced
this pull request
Nov 6, 2020
PR-URL: #35885 Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Nov 9, 2020
PR-URL: #35885 Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Dec 9, 2020
PR-URL: #35885 Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Dec 10, 2020
PR-URL: #35885 Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Dec 15, 2020
PR-URL: #35885 Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FWIW I'm using
ReflectApplyto replace uses ofFunction.prototype.applyandFunction.prototype.callbecause it has less overhead (see #35838 (review) for more info).Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passe