Uh oh!
There was an error while loading. Please reload this page.
crypto: pass empty passphrases to OpenSSL properly - #35914
Closed
tniessen wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
Nov 1, 2020
Collaborator
Review requested:
|
addaleax
approved these changes
Nov 1, 2020
Uh oh!
There was an error while loading. Please reload this page.
tniessenforce-pushed
the
crypto-fix-blank-passphrase-35898
branch
from
November 1, 2020 22:46
75b73df to
17654c6Comparefhinkel
approved these changes
Nov 2, 2020
jasnell
approved these changes
Nov 2, 2020
cjihrig
approved these changes
Nov 2, 2020
Trott
approved these changes
Nov 2, 2020
tniessenforce-pushed
the
crypto-fix-blank-passphrase-35898
branch
from
November 2, 2020 16:11
17654c6 to
6c6a42dComparetniessenforce-pushed
the
crypto-fix-blank-passphrase-35898
branch
from
November 2, 2020 16:26
6c6a42d to
6e328e4Comparenodejs-github-bot
commented
Nov 2, 2020
Collaborator
nodejs-github-bot
commented
Nov 3, 2020
Collaborator
tniessen added a commit
that referenced
this pull request
Nov 4, 2020
Fixes: #35898 PR-URL: #35914 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
tniessen
commented
Nov 4, 2020
MemberAuthor
Landed in 9aafda5, thank you for reviewing! |
targos pushed a commit
that referenced
this pull request
Nov 4, 2020
Fixes: #35898 PR-URL: #35914 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
| // intentionally use a pointer that will likely cause a segmentation fault | ||
| // when dereferenced. | ||
| CHECK_EQ(pass_len, 0); | ||
| pass = reinterpret_cast<char*>(-1); |
Member
There was a problem hiding this comment.
Somewhat belatedly... forging pointers is technically UB and can lead to miscompiles, even if the pointer is never dereferenced. I get why it's doing what it's doing but I would suggest to just set pass = "";
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves two related problems:
PrivateKeyEncodingConfigwas unable to distinguish between "no passphrase" and zero-length passphrases, since both may be stored asByteSource(nullptr, 0).nullptrfor the passphrase. However, this did happen when an empty passphrase was specified, becausemalloc(0)is allowed to return anullptr.I'm not sure why these problems don't affect older versions.
Fixes: #35898
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes