Skip to content

build: fix lint-js-fix target - #35927

Closed
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:fix-lint-js-fix
Closed

build: fix lint-js-fix target#35927
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:fix-lint-js-fix

Conversation

@aduh95

@aduh95aduh95 commented Nov 2, 2020

Copy link
Copy Markdown
Contributor
$ make lint-js-fixNo value for 'ext' specified.make: *** [lint-js-fix] Error 2

Bug introduced in #35708

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@aduh95aduh95 added build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 2, 2020
@aduh95

aduh95 commented Nov 2, 2020

Copy link
Copy Markdown
ContributorAuthor

Fast track?

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2020
@nodejs-github-bot

nodejs-github-bot commented Nov 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34020/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 2, 2020
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 2, 2020
@github-actions

github-actionsBot commented Nov 2, 2020•
edited by aduh95
Loading

Copy link
Copy Markdown
Contributor

Landed in bf6883d

nodejs-github-bot pushed a commit that referenced this pull request Nov 2, 2020
@aduh95@nodejs-github-bot
build: fix lint-js-fix target
bf6883d
Refs: #35708
PR-URL: #35927
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@aduh95
aduh95 deleted the fix-lint-js-fix branch November 2, 2020 22:48
targos pushed a commit that referenced this pull request Nov 3, 2020
@aduh95@targos
build: fix lint-js-fix target
b11c737
Refs: #35708
PR-URL: #35927
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targostargos mentioned this pull request Nov 3, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@aduh95@BethGriggs
build: fix lint-js-fix target
a389a72
Refs: #35708
PR-URL: #35927
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@aduh95@BethGriggs
build: fix lint-js-fix target
a01802d
Refs: #35708
PR-URL: #35927
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@aduh95@BethGriggs
build: fix lint-js-fix target
f33fa26
Refs: #35708
PR-URL: #35927
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes
@lpincalpincalpinca approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95@nodejs-github-bot@benjamingr@lpinca@richardlau