Uh oh!
There was an error while loading. Please reload this page.
win, build: fix build time on Windows - #35932
Closed
bzoz wants to merge 1 commit into
Closed
Conversation
Sets MSBuild experimental switches to make it build in parallel project files generated by gyp 0.5.0. Fixes: nodejs#35921
nodejs-github-bot
commented
Nov 2, 2020
Collaborator
richardlau
commented
Nov 2, 2020
Member
@bzoz Will these changes work for VS 2017? If not, we should add appropriate |
bzoz
commented
Nov 2, 2020
ContributorAuthor
@richardlau the thread where those are mentioned is about VS2017, so I guess they should work. I'll give it a try. |
addaleax
approved these changes
Nov 2, 2020
bzoz
commented
Nov 2, 2020
ContributorAuthor
This does not have any effect on VS2017. The build works, but it is still slow. |
cjihrig
approved these changes
Nov 2, 2020
richardlau
approved these changes
Nov 2, 2020
gengjiawen
approved these changes
Nov 3, 2020
gireeshpunathil
approved these changes
Nov 3, 2020
Trott
approved these changes
Nov 3, 2020
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 7, 2020
Sets MSBuild experimental switches to make it build in parallel project files generated by gyp 0.5.0. Fixes: nodejs#35921 PR-URL: nodejs#35932 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
commented
Nov 7, 2020
Member
Landed in bfc9847 |
danielleadams pushed a commit
that referenced
this pull request
Nov 9, 2020
Sets MSBuild experimental switches to make it build in parallel project files generated by gyp 0.5.0. Fixes: #35921 PR-URL: #35932 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Dec 9, 2020
Sets MSBuild experimental switches to make it build in parallel project files generated by gyp 0.5.0. Fixes: #35921 PR-URL: #35932 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Dec 10, 2020
Sets MSBuild experimental switches to make it build in parallel project files generated by gyp 0.5.0. Fixes: #35921 PR-URL: #35932 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Dec 15, 2020
Sets MSBuild experimental switches to make it build in parallel project files generated by gyp 0.5.0. Fixes: #35921 PR-URL: #35932 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets MSBuild experimental switches to make it build in parallel project files generated by gyp 0.5.0.
Fixes: #35921
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes