Uh oh!
There was an error while loading. Please reload this page.
tools: don't print gold linker warning w/o flag - #35955
Closed
MylesBorins wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
Nov 4, 2020
Collaborator
joyeecheung
commented
Nov 4, 2020
Member
I think you meant |
Uh oh!
There was an error while loading. Please reload this page.
MylesBorinsforce-pushed
the
limit-configure-section-file
branch
from
November 4, 2020 05:32
31563ac to
c275e6dCompareMylesBorins
commented
Nov 4, 2020
ContributorAuthor
@joyeecheung I opted to instead surpress the warning if the flag hasn't been passed. Thoughts? |
crypt096
approved these changes
Nov 4, 2020
joyeecheung
approved these changes
Nov 5, 2020
richardlau
approved these changes
Nov 5, 2020
nodejs-github-bot
commented
Nov 5, 2020
Collaborator
Trott
approved these changes
Nov 6, 2020
nodejs-github-bot
commented
Nov 6, 2020
Collaborator
nodejs-github-bot
commented
Nov 6, 2020
Collaborator
Currently warning is printed called even if the selection ordering flag has not been passed. Only print warning if `--limit-configure-section-file` has been passed to configure. Fixes: nodejs#35872
MylesBorinsforce-pushed
the
limit-configure-section-file
branch
from
November 6, 2020 19:35
c275e6d to
9d48454CompareMylesBorins
commented
Nov 6, 2020
ContributorAuthor
don't know what's going on with CI, all failures unrelated. Rebasing against master and trying again. For those who have signed off already there have been 0 changes to the change since the reviewes |
nodejs-github-bot
commented
Nov 6, 2020
Collaborator
nodejs-github-bot
commented
Nov 7, 2020
Collaborator
richardlau
approved these changes
Nov 7, 2020
Contributor
Landed in cef1444...115722b |
nodejs-github-bot pushed a commit
that referenced
this pull request
Nov 7, 2020
Currently warning is printed called even if the selection ordering flag has not been passed. Only print warning if `--limit-configure-section-file` has been passed to configure. Fixes: #35872 PR-URL: #35955 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Nov 9, 2020
Currently warning is printed called even if the selection ordering flag has not been passed. Only print warning if `--limit-configure-section-file` has been passed to configure. Fixes: #35872 PR-URL: #35955 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Dec 9, 2020
Currently warning is printed called even if the selection ordering flag has not been passed. Only print warning if `--limit-configure-section-file` has been passed to configure. Fixes: #35872 PR-URL: #35955 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Dec 10, 2020
Currently warning is printed called even if the selection ordering flag has not been passed. Only print warning if `--limit-configure-section-file` has been passed to configure. Fixes: #35872 PR-URL: #35955 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Dec 15, 2020
Currently warning is printed called even if the selection ordering flag has not been passed. Only print warning if `--limit-configure-section-file` has been passed to configure. Fixes: #35872 PR-URL: #35955 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently configure_section_file is called even if the appropriate
flag has not been passed which is causing a warning to be printed
on all calls to configure without the flag.
Only call configure_section_file if
--limit-configure-section-filehas been passed to configure.
Fixes: #35872