Skip to content

http2: delay session.receive() by a tick - #35985

Merged
Trott merged 1 commit into
nodejs:masterfrom
szmarczak:fix-receive
Nov 11, 2020
Merged

http2: delay session.receive() by a tick#35985
Trott merged 1 commit into
nodejs:masterfrom
szmarczak:fix-receive

Conversation

@szmarczak

@szmarczakszmarczak commented Nov 5, 2020•
edited
Loading

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Fixes#35981

@nodejs-github-bot

nodejs-github-bot commented Nov 5, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-botnodejs-github-bot added the http2 Issues or PRs related to the http2 subsystem. label Nov 5, 2020
mcollina
mcollina approved these changes Nov 7, 2020
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollinamcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2020
@nodejs-github-bot

nodejs-github-bot commented Nov 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34160/

Trott
Trott reviewed Nov 8, 2020
View reviewed changes
Comment threadlib/internal/http2/core.js Outdated
Trott
Trott reviewed Nov 8, 2020
View reviewed changes
Comment threadlib/internal/http2/core.js Outdated
@mcollinamcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2020
@szmarczak

szmarczak commented Nov 8, 2020

Copy link
Copy Markdown
MemberAuthor

@Trott PTAL.

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2020
@nodejs-github-bot

nodejs-github-bot commented Nov 8, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34216/

@nodejs-github-bot

nodejs-github-bot commented Nov 10, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34295/

@szmarczak@Trott
http2: delay session.receive() by a tick
564fcb8
PR-URL: nodejs#35985
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Trott merged commit 564fcb8 into nodejs:masterNov 11, 2020
@Trott

Trott commented Nov 11, 2020

Copy link
Copy Markdown
Member

Landed in 564fcb8

codebytere pushed a commit that referenced this pull request Nov 22, 2020
@szmarczak@codebytere
http2: delay session.receive() by a tick
0b40568
PR-URL: #35985
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebyterecodebytere mentioned this pull request Nov 22, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
@szmarczak@BethGriggs
http2: delay session.receive() by a tick
69016b8
PR-URL: #35985
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@szmarczak@BethGriggs
http2: delay session.receive() by a tick
0fbcc75
PR-URL: #35985
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@szmarczak@BethGriggs
http2: delay session.receive() by a tick
ab2b066
PR-URL: #35985
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@TrottTrottTrott approved these changes

Assignees

No one assigned

Labels

http2Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

remoteSettings event is not emitted on a HTTP/2 session when given a socket with some data

4 participants

@szmarczak@nodejs-github-bot@Trott@mcollina