Uh oh!
There was an error while loading. Please reload this page.
upgrade npm to 3.3.10 - #3599
Conversation
Fishrock123
commented
Oct 30, 2015
Will this help #3601 at all? |
iarna
commented
Oct 30, 2015
I'd love to continue refining this over time to make |
iarna
commented
Oct 30, 2015
Fishrock123
commented
Oct 30, 2015
Doh, forgot about that. |
iarna
commented
Nov 2, 2015
@silverwind Previously a relative entry was tried and that didn't work. If anyone can figure out how to do that, it would obviously be much preferred. And yes, someday npm's deps will be flatified and we'll have to update the .gitignore when we do that. To that end...
|
Fishrock123
commented
Nov 2, 2015
This works happily even without |
PR-URL: #3599 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
PR-URL: #3599 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
PR-URL: #3599 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Fishrock123
commented
Nov 2, 2015
Thanks again, landed in 827ee49...507fc53 :) |
iarna
commented
Nov 2, 2015
My test protocol now involves setting my path to not include node or npm before running the tests, so we shouldn't reintroduce that kind of problem. |
PR-URL: #3599 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
PR-URL: #3599 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
PR-URL: #3599 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Please find enclosed:
An update to
.gitignoresuch that the debug module used by one of npm's dependencies won't be ignored again. It's worth noting that if this module ever moves in thenode_modulesfolder that this.gitignoreexception will have to be updated.An update
test-npm.shto use the npm 3.3.10test-nodescript for kicking off the tests. We also now callnpm rebuildin order to link in the binaries associated with the regular dependencies back in, as some tests need them. This wasn't required previously due to a bug that was triggering rebuilds at inappropriate times.And npm@3.3.10 – the last version included in node was 3.3.6 and since then the following notable changes have been made:
npm@2– this was necessary to allow the npm bundled with node v8 to upgrade. We'll likely go back to flat deps innpm@3someday, but have no immediate plans to do so at this time.npm rebuildbeing called far more often than intended during builds. This also meant that failures during this extraneous rebuild phase could cause optional deps to abort the install, instead of simply failing that one module.npm shrinkwrapwill now complete successfully even if optional dependencies are missing.npm install --save.(As always, the full details are available in our changelog)
r: @Fishrock123
r: @chrisdickinson