Skip to content

fs: replace finally with PromisePrototypeFinally - #35995

Closed
baruchiro wants to merge 1 commit into
nodejs:masterfrom
baruchiro:patch-1
Closed

fs: replace finally with PromisePrototypeFinally#35995
baruchiro wants to merge 1 commit into
nodejs:masterfrom
baruchiro:patch-1

Conversation

@baruchiro

@baruchirobaruchiro commented Nov 6, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

See suggestion here- #35993 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Nov 6, 2020
@baruchirobaruchiro mentioned this pull request Nov 6, 2020
Closed
benjamingr
benjamingr reviewed Nov 6, 2020
View reviewed changes
Comment threadlib/internal/fs/promises.js Outdated
@aduh95

aduh95 commented Nov 6, 2020

Copy link
Copy Markdown
Contributor

If you could change other .finally calls in this file as well, that'd be nice.

@baruchiro

baruchiro commented Nov 7, 2020

Copy link
Copy Markdown
ContributorAuthor

Sorry for the force push, I following the commit guidelines now (I hope)

@baruchirobaruchiro changed the title Suggested refactor by #35993fs: replace finally with PromisePrototypeFinallyNov 7, 2020
@aduh95

aduh95 commented Nov 7, 2020

Copy link
Copy Markdown
Contributor

@baruchiro Can you rebase to resolve the conflict please?

git fetch upstream master
git rebase upstream/master -i

@baruchiro

baruchiro commented Nov 8, 2020

Copy link
Copy Markdown
ContributorAuthor

About initializing the workspace and running vcbuild test, I found a bug in the vcbuild.bat file related to *Visual Studio 19 Preview`, I have one fix for that (but it not solving the whole process).

Where should I open a bug and/or PR for that?

(PR will be here, of course... But should I open an issue first? Do I need to open the issue in the current repo, even if it not related to node itself, but to the repo itself?)

@aduh95

aduh95 commented Nov 8, 2020

Copy link
Copy Markdown
Contributor

Where should I open a bug and/or PR for that?

If you have a fix, PR is very welcome. Issue is not necessary if your PR describes the problem and the solution.

@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2020
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 8, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Nov 8, 2020•
edited by aduh95
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34203/ ✅

@baruchiro

baruchiro commented Nov 9, 2020

Copy link
Copy Markdown
ContributorAuthor

@benjamingr As first-time contributor I allow myself to ask "what now?"

When this PR will be merged?
Do I need to do something?

@aduh95

aduh95 commented Nov 9, 2020

Copy link
Copy Markdown
Contributor

@baruchiro Your PR is author ready, that means you don't have anything left to do :) You just have to wait for someone landing it for you on master. You can read more about what's the process here: https://github.com/nodejs/node/blob/master/doc/guides/collaborator-guide.md#accepting-modifications

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 9, 2020
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 9, 2020
@github-actions

github-actionsBot commented Nov 9, 2020

Copy link
Copy Markdown
Contributor

Landed in 36fbbe0...a8b9ede

nodejs-github-bot pushed a commit that referenced this pull request Nov 9, 2020
@baruchiro@nodejs-github-bot
fs: replace finally with PromisePrototypeFinally
a8b9ede
#35993 (comment)
PR-URL: #35995
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@baruchiro

baruchiro commented Nov 9, 2020

Copy link
Copy Markdown
ContributorAuthor

@aduh95 So it actually taked my commits into master, but not by the Github PR interface?

Interesting technique 😀

@aduh95

aduh95 commented Nov 9, 2020

Copy link
Copy Markdown
Contributor

@baruchiro yes, the reasons are outlined here: https://github.com/nodejs/node/blob/master/doc/guides/collaborator-guide.md#landing-pull-requests

But anyway, you are now officially a Node.js contributor, congrats 🎉

@baruchiro
baruchiro deleted the patch-1 branch November 9, 2020 19:15
@baruchiro

baruchiro commented Nov 9, 2020

Copy link
Copy Markdown
ContributorAuthor

Hooray!! 🥇

But now I can't write that in my CV, because I don't know how to answer the question "What you did as a Node.js contributor?"... 😉😉

Never mind, I'm sure the next contribution I will understand more. I just need to find the next one.

@benjamingr

benjamingr commented Nov 9, 2020

Copy link
Copy Markdown
Member

Feel free to ping me on Facebook for more contribution ideas :)

danielleadams pushed a commit that referenced this pull request Nov 10, 2020
@baruchiro@danielleadams
fs: replace finally with PromisePrototypeFinally
7ef9c70
#35993 (comment)
PR-URL: #35995
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Nov 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
@baruchiro@BethGriggs
fs: replace finally with PromisePrototypeFinally
1ed0a03
#35993 (comment)
PR-URL: #35995
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@baruchiro@BethGriggs
fs: replace finally with PromisePrototypeFinally
affa710
#35993 (comment)
PR-URL: #35995
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@baruchiro@BethGriggs
fs: replace finally with PromisePrototypeFinally
7c3b6f1
#35993 (comment)
PR-URL: #35995
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr left review comments
@TrottTrottTrott approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@baruchiro@aduh95@nodejs-github-bot@benjamingr@Trott