Skip to content

assert: refactor to use more primordials - #35998

Closed
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:assert-more-primodials
Closed

assert: refactor to use more primordials#35998
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:assert-more-primodials

Conversation

@aduh95

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the assert Issues and PRs related to the assert subsystem. label Nov 6, 2020
@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2020
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95aduh95 added the review wanted PRs that need reviews. label Nov 8, 2020
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 10, 2020
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 13, 2020
@github-actions

Copy link
Copy Markdown
Contributor

Landed in 8656ab4...d8f66c1

nodejs-github-bot pushed a commit that referenced this pull request Nov 13, 2020
PR-URL: #35998
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95
aduh95 deleted the assert-more-primodials branch November 14, 2020 10:32
codebytere pushed a commit that referenced this pull request Nov 22, 2020
PR-URL: #35998
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebyterecodebytere mentioned this pull request Nov 22, 2020
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
PR-URL: #35998
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
PR-URL: #35998
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 10, 2020
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
PR-URL: #35998
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assertIssues and PRs related to the assert subsystem.author readyPRs that have at least one approval, no pending requests for changes, and a CI started.review wantedPRs that need reviews.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@aduh95@nodejs-github-bot@Trott