Uh oh!
There was an error while loading. Please reload this page.
crypto: refactor to use more primordials - #36012
Merged
Merged
Conversation
nodejs-github-bot
commented
Nov 6, 2020
Collaborator
Review requested:
|
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Nov 7, 2020
nodejs-github-bot
commented
Nov 7, 2020
Collaborator
Trott
approved these changes
Nov 10, 2020
Trottforce-pushed
the
crypto-primordials
branch
from
November 10, 2020 04:23
12b9d9f to
da53a3cCompareTrott
commented
Nov 10, 2020
Member
Landed in da53a3c |
danielleadams pushed a commit
that referenced
this pull request
Nov 10, 2020
PR-URL: #36012 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes