Uh oh!
There was an error while loading. Please reload this page.
tools,lib: tighten prefer-primordials rules for Error methods - #36017
Merged
Conversation
3 tasks
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
Nov 7, 2020
Collaborator
Leko
approved these changes
Nov 7, 2020
ExE-Boss
commented
Nov 8, 2020
Contributor
The commit message should probably be: |
Trott
approved these changes
Nov 9, 2020
PR-URL: nodejs#36017 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trottforce-pushed
the
error-prefer-primordials
branch
from
November 9, 2020 14:08
064dd4f to
8f95438CompareTrott
commented
Nov 9, 2020
Member
danielleadams pushed a commit
that referenced
this pull request
Nov 9, 2020
PR-URL: #36017 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
targos pushed a commit
that referenced
this pull request
May 16, 2021
PR-URL: #36017 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #36017 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes