tools,lib: refactor prefer-primordials rule by aduh95 · Pull Request #36018 · nodejs/node

aduh95 · 2020-11-07T12:10:42Z

Refactor the ESLint rule source code to improve readability.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

nodejs-github-bot · 2020-11-07T12:13:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/34164/

Leko

Could you separate this pull request for each purpose?

Refactoring of the rule
Add Safe prefix on the Map and Set, etc.
Replace prototype property with primordials.

aduh95 · 2020-11-07T17:10:50Z

@Leko I've split the PR as requested (#36025 and #36026).
This is blocked by #36025 and the node-test-linter failure due to the lack of support for optional chaining and null coalescing operator.

Trott · 2020-11-14T14:22:11Z

Not sure if this needs to be rebased or closed (since it overlaps with PRs that landed?) but one or the other.

nodejs-github-bot · 2020-11-14T19:11:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/34399/

nodejs-github-bot · 2020-12-21T13:07:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/35022/

richardlau · 2020-12-21T15:16:41Z

Blocked on nodejs/build#2504.

ExE-Boss · 2021-02-15T12:12:20Z

nodejs/build#2504 has now been fixed by nodejs/build#2514.

nodejs-github-bot · 2021-02-15T13:29:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/36137/

nodejs-github-bot · 2021-02-15T15:12:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/36142/

aduh95 · 2021-02-15T17:02:15Z

@Leko I think this is ready to land, would you kindly have another look at this PR, I believe I've addressed all your objections.

Leko

@aduh95 Thank you for a lot of works to support optional chaining! LGTM

Use optional chaining to improve code readability and remove use of `Array.prototype.reduce`. PR-URL: nodejs#36018 Reviewed-By: Shingo Inoue <leko.noor@gmail.com>

aduh95 · 2021-02-16T16:59:24Z

Landed in 7fd6c20

Use optional chaining to improve code readability and remove use of `Array.prototype.reduce`. PR-URL: #36018 Reviewed-By: Shingo Inoue <leko.noor@gmail.com>

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2020

aduh95 requested a review from Leko November 7, 2020 12:10

nodejs-github-bot added process Issues and PRs related to the process subsystem. tools Issues and PRs related to the tools directory. labels Nov 7, 2020

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2020

Leko suggested changes Nov 7, 2020
View reviewed changes

Comment threadtools/eslint-rules/prefer-primordials.js Outdated
Comment threadtest/parallel/test-eslint-prefer-primordials.js Outdated

Leko suggested changes Nov 7, 2020
View reviewed changes

Comment threadlib/.eslintrc.yaml Outdated

aduh95 force-pushed the prefer-primordials-refactor branch from 5ef69fb to 601d050Compare November 7, 2020 16:45

aduh95 requested a review from Leko November 7, 2020 16:46

aduh95 added the blocked PRs that are blocked by other issues or PRs. label Nov 7, 2020

aduh95 force-pushed the prefer-primordials-refactor branch from 601d050 to 599119cCompare November 14, 2020 19:02

aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed blocked PRs that are blocked by other issues or PRs. labels Nov 14, 2020

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2020

aduh95 mentioned this pull request Dec 21, 2020
Upgrade Node.js version on node-test-linter job nodejs/build#2504
Closed

richardlau added the blocked PRs that are blocked by other issues or PRs. label Dec 21, 2020

richardlau removed the blocked PRs that are blocked by other issues or PRs. label Feb 15, 2021

Leko approved these changes Feb 16, 2021
View reviewed changes

aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 16, 2021

tools: refactor prefer-primordials
7fd6c20
Use optional chaining to improve code readability and remove use of `Array.prototype.reduce`. PR-URL: nodejs#36018 Reviewed-By: Shingo Inoue <leko.noor@gmail.com>

aduh95 force-pushed the prefer-primordials-refactor branch from 599119c to 7fd6c20Compare February 16, 2021 16:58

aduh95 merged commit 7fd6c20 into nodejs:masterFeb 16, 2021

aduh95 deleted the prefer-primordials-refactor branch February 16, 2021 16:59

danielleadams pushed a commit that referenced this pull request Feb 16, 2021
tools: refactor prefer-primordials
2e1f1c6
Use optional chaining to improve code readability and remove use of `Array.prototype.reduce`. PR-URL: #36018 Reviewed-By: Shingo Inoue <leko.noor@gmail.com>

This was referenced Feb 16, 2021
v15.9.0 proposal #37405
Closed
v15.9.0 proposal #37406
Merged

targos pushed a commit that referenced this pull request May 27, 2021
tools: refactor prefer-primordials
064893d
Use optional chaining to improve code readability and remove use of `Array.prototype.reduce`. PR-URL: #36018 Reviewed-By: Shingo Inoue <leko.noor@gmail.com>

targos pushed a commit that referenced this pull request May 30, 2021
tools: refactor prefer-primordials
e8f4177
Use optional chaining to improve code readability and remove use of `Array.prototype.reduce`. PR-URL: #36018 Reviewed-By: Shingo Inoue <leko.noor@gmail.com>

targos pushed a commit that referenced this pull request Jun 5, 2021
tools: refactor prefer-primordials
dfb4e5f
Use optional chaining to improve code readability and remove use of `Array.prototype.reduce`. PR-URL: #36018 Reviewed-By: Shingo Inoue <leko.noor@gmail.com>

targos mentioned this pull request Jun 6, 2021
v14.17.1 release proposal #38948
Merged

targos pushed a commit that referenced this pull request Jun 11, 2021
tools: refactor prefer-primordials
a4dd50f
Use optional chaining to improve code readability and remove use of `Array.prototype.reduce`. PR-URL: #36018 Reviewed-By: Shingo Inoue <leko.noor@gmail.com>

Uh oh!

Uh oh!

Conversation

aduh95 commented Nov 7, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

nodejs-github-bot commented Nov 7, 2020

Uh oh!

Leko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aduh95 commented Nov 7, 2020

Uh oh!

Trott commented Nov 14, 2020

Uh oh!

nodejs-github-bot commented Nov 14, 2020

Uh oh!

nodejs-github-bot commented Dec 21, 2020

Uh oh!

richardlau commented Dec 21, 2020

Uh oh!

ExE-Boss commented Feb 15, 2021

Uh oh!

nodejs-github-bot commented Feb 15, 2021

Uh oh!

nodejs-github-bot commented Feb 15, 2021

Uh oh!

aduh95 commented Feb 15, 2021

Uh oh!

Leko left a comment

Choose a reason for hiding this comment

Uh oh!

aduh95 commented Feb 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

aduh95 commented Nov 7, 2020•
edited
Loading