Skip to content

tools: enforce use of single quotes in editorconfig - #36020

Closed
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:single-quotes
Closed

tools: enforce use of single quotes in editorconfig#36020
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:single-quotes

Conversation

@aduh95

Copy link
Copy Markdown
Contributor

This is to avoid text editor to replace quotes by double quotes.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2020
@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 7, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2020
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 7, 2020
@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 12, 2020
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 12, 2020
@github-actions

Copy link
Copy Markdown
Contributor

Landed in f6ada62...ba73f93

nodejs-github-bot pushed a commit that referenced this pull request Nov 12, 2020
PR-URL: #36020
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95
aduh95 deleted the single-quotes branch November 12, 2020 09:58
codebytere pushed a commit that referenced this pull request Nov 22, 2020
PR-URL: #36020
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebyterecodebytere mentioned this pull request Nov 22, 2020
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
PR-URL: #36020
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
PR-URL: #36020
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 10, 2020
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
PR-URL: #36020
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95@nodejs-github-bot@Trott@lpinca