Skip to content

test: update wpt url and resource - #36032

Closed
watilde wants to merge 1 commit into
nodejs:masterfrom
watilde:wpt-url-update
Closed

test: update wpt url and resource#36032
watilde wants to merge 1 commit into
nodejs:masterfrom
watilde:wpt-url-update

Conversation

@watilde

Copy link
Copy Markdown
Member

percent-encoding.window.js file was added and will be paused to use as same as toascii.window.js for now.

Refs: web-platform-tests/wpt#26317

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@watildewatilde added test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 8, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2020
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@watilde

Copy link
Copy Markdown
MemberAuthor

Let me cc @nodejs/url to request your review

@watildewatilde added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 16, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2020
@nodejs-github-bot

This comment has been minimized.

@watildewatilde added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2020
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

watilde added a commit that referenced this pull request Nov 19, 2020
Refs: web-platform-tests/wpt#26317
PR-URL: #36032
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@watilde

Copy link
Copy Markdown
MemberAuthor

Landed in d6d4721

@watildewatilde closed this Nov 19, 2020
@watilde
watilde deleted the wpt-url-update branch November 19, 2020 02:33
codebytere pushed a commit that referenced this pull request Nov 22, 2020
Refs: web-platform-tests/wpt#26317
PR-URL: #36032
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@codebyterecodebytere mentioned this pull request Nov 22, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.whatwg-urlIssues and PRs related to the WHATWG URL implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@watilde@nodejs-github-bot@Trott@targos@joyeecheung