net: Fix invalid write after end error by ronag · Pull Request #36043 · nodejs/node

ronag · 2020-11-08T18:57:57Z

Don't error if not ended.

Fixes: #36029

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2020-11-08T18:58:01Z

Review requested:

@nodejs/net
@nodejs/quic

Don't error if not ended. Fixes: nodejs#36029

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

mcollina

lgtm

Should this be backported to v14 or v12?

mscdex · 2020-11-09T09:20:23Z

@mcollina Only if efefdd6 ever gets backported to those branches

mcollina · 2020-11-09T09:31:57Z

that's semver-major, so no.

mcollina · 2020-11-09T09:32:13Z

Thanks @mscdex!

Trott · 2020-11-09T14:22:59Z

The test-stream-transform-end.js test file added here is timing out in GitHub CI.

nodejs-github-bot · 2020-11-09T20:09:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/34258/

nodejs-github-bot · 2020-11-10T10:34:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/34279/

github-actions · 2020-11-10T17:01:28Z

Commit Queue failed

- Loading data for nodejs/node/pull/36043
✔ Done loading data for nodejs/node/pull/36043
----------------------------------- PR info ------------------------------------
Title net: Fix invalid write after end error (#36043)
Author Robert Nagy (@ronag)
Branch ronag:net-write-after-end-no-half-open -> nodejs:master
Labels author ready, dont-land-on-v10.x, dont-land-on-v12.x, dont-land-on-v14.x, net
Commits 8
- net: Fix invalid write after end error
- fixup
- Update lib/net.js
- fixup
- fixup
- fixup
- fixup
- fixup
Committers 2
- Robert Nagy - GitHub PR-URL: https://github.com/nodejs/node/pull/36043
Fixes: https://github.com/nodejs/node/issues/36029
Reviewed-By: Matteo Collina Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36043
Fixes: https://github.com/nodejs/node/issues/36029
Reviewed-By: Matteo Collina Reviewed-By: Luigi Pinca --------------------------------------------------------------------------------
⚠ Commits were pushed since the last review:
⚠ - fixup
✔ Last GitHub Actions successful
ℹ Last Full PR CI on 2020-11-10T10:34:15Z: https://ci.nodejs.org/job/node-test-pull-request/34279/
- Querying data for job/node-test-pull-request/34279/
✔ Build data downloaded
✔ Last Jenkins CI successful
ℹ This PR was created on Sun, 08 Nov 2020 18:57:57 GMT
✔ Approvals: 2
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/36043#pullrequestreview-525942020
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36043#pullrequestreview-526614630
✖ This PR needs to wait 1 more hours to land
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

Commit Queue action: https://github.com/nodejs/node/actions/runs/356263944

github-actions · 2020-11-10T20:22:24Z

Commit Queue failed

- Loading data for nodejs/node/pull/36043
✔ Done loading data for nodejs/node/pull/36043
----------------------------------- PR info ------------------------------------
Title net: Fix invalid write after end error (#36043)
Author Robert Nagy (@ronag)
Branch ronag:net-write-after-end-no-half-open -> nodejs:master
Labels author ready, commit-queue, dont-land-on-v10.x, dont-land-on-v12.x, dont-land-on-v14.x, net
Commits 8
- net: Fix invalid write after end error
- fixup
- Update lib/net.js
- fixup
- fixup
- fixup
- fixup
- fixup
Committers 2
- Robert Nagy - GitHub PR-URL: https://github.com/nodejs/node/pull/36043
Fixes: https://github.com/nodejs/node/issues/36029
Reviewed-By: Matteo Collina Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36043
Fixes: https://github.com/nodejs/node/issues/36029
Reviewed-By: Matteo Collina Reviewed-By: Luigi Pinca --------------------------------------------------------------------------------
⚠ Commits were pushed since the last review:
⚠ - fixup
✔ Last GitHub Actions successful
ℹ Last Full PR CI on 2020-11-10T17:01:28Z: https://ci.nodejs.org/job/node-test-pull-request/34279/
- Querying data for job/node-test-pull-request/34279/
✔ Build data downloaded
✔ Last Jenkins CI successful
ℹ This PR was created on Sun, 08 Nov 2020 18:57:57 GMT
✔ Approvals: 2
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/36043#pullrequestreview-525942020
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36043#pullrequestreview-526614630
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

Commit Queue action: https://github.com/nodejs/node/actions/runs/356556511

aduh95 · 2020-11-10T23:27:50Z

Landed in f7f0a6a

Don't error if not ended. Fixes: #36029 PR-URL: #36043 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

ronag added the net Issues and PRs related to the net subsystem. label Nov 8, 2020

ronag requested review from jasnell, mcollina and mscdex November 8, 2020 18:57

ronag added dont-land-on-v10.x labels Nov 8, 2020

net: Fix invalid write after end error
1f73c8a
Don't error if not ended. Fixes: nodejs#36029

ronag force-pushed the net-write-after-end-no-half-open branch from 4c50922 to 1f73c8aCompare November 8, 2020 18:58

aduh95 reviewed Nov 8, 2020
View reviewed changes

Comment threadlib/net.js Outdated

mscdex reviewed Nov 8, 2020
View reviewed changes

Comment threadtest/parallel/test-net-writable.js Outdated

mscdex reviewed Nov 8, 2020
View reviewed changes

Comment threadtest/parallel/test-net-writable.js Outdated

ronagand others added 2 commits November 8, 2020 23:27

fixup
819b441

Update lib/net.js
fef1845
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

mcollina approved these changes Nov 9, 2020
View reviewed changes

fixup
d1bce40

lpinca reviewed Nov 9, 2020
View reviewed changes

Comment threadtest/parallel/test-net-writable.js

fixup
d9d5b77

ronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 9, 2020

lpinca reviewed Nov 9, 2020
View reviewed changes

Comment threadtest/parallel/test-stream-transform-end.js Outdated

fixup
1fbd2eb

lpinca approved these changes Nov 9, 2020
View reviewed changes

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2020

fixup
a0ea1b0

ronag force-pushed the net-write-after-end-no-half-open branch from 61d67ad to a0ea1b0Compare November 9, 2020 22:52

fixup
e34e3bc

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2020

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2020

ronag added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2020

github-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2020

github-actionsBot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Nov 10, 2020

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 10, 2020

github-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2020

github-actionsBot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Nov 10, 2020

aduh95 closed this Nov 10, 2020

aduh95 pushed a commit that referenced this pull request Nov 10, 2020
net: fix invalid write after end error
f7f0a6a
Don't error if not ended. Fixes: #36029 PR-URL: #36043 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

codebytere pushed a commit that referenced this pull request Nov 22, 2020
net: fix invalid write after end error
5c0ddbc
Don't error if not ended. Fixes: #36029 PR-URL: #36043 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

codebytere mentioned this pull request Nov 22, 2020
v15.3.0 proposal #36232
Merged

targos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021

Uh oh!

Uh oh!

Conversation

ronag commented Nov 8, 2020

Checklist

Uh oh!

nodejs-github-bot commented Nov 8, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

mscdex commented Nov 9, 2020

Uh oh!

mcollina commented Nov 9, 2020

Uh oh!

mcollina commented Nov 9, 2020

Uh oh!

Trott commented Nov 9, 2020

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Nov 9, 2020

Uh oh!

nodejs-github-bot commented Nov 10, 2020

Uh oh!

github-actionsBot commented Nov 10, 2020

Uh oh!

github-actionsBot commented Nov 10, 2020

Uh oh!

aduh95 commented Nov 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants