Uh oh!
There was an error while loading. Please reload this page.
doc: ESM documentation consolidation and reordering - #36046
Conversation
nodejs-github-bot
commented
Nov 9, 2020
Review requested:
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Trott
left a comment
There was a problem hiding this comment.
LGTM. While we're at it, I wouldn't mind a switch from builtin to built-in but that may be a "tabs vs. spaces" kind of discussion, so I'm OK with this as it is.
GeoffreyBooth
left a comment
There was a problem hiding this comment.
Thank you for doing this!
guybedford
commented
Nov 11, 2020
I know we were nearly ready to go on this, but I just took a look today and ended up putting a little more time into reworking the differences section. See c4258d2 for the latest commit. The gist of the new changes are the last bullet points in the description of this issue:
|
guybedford
commented
Nov 12, 2020
@devsnek I've posted an update to remove the example, and mentioned |
Uh oh!
There was an error while loading. Please reload this page.
guybedford
commented
Nov 13, 2020
With the new link to |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Rich Trott <rtrott@gmail.com>
PR-URL: #36046 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
guybedford
commented
Nov 15, 2020
Landed in 187ce5b. |
PR-URL: #36046 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
PR-URL: #36046 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
PR-URL: #36046 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
PR-URL: #36046 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
broofa
commented
Dec 16, 2020
This PR removed the [very helpful] example for how to reproduce the |
guybedford
commented
Dec 16, 2020
@broofa all the examples intentionally use the |
I just went through the
esm.mddocs and consolidated sections where it seemed to make sense as well as reordering the structure slightly now that the layout of this page is finally stable.Changes include:
> Stabilitynote.file:,data:andnode:URLs. Brought all the file resolution considerations under the "file:Imports" heading here.pathToFileURL/or//import.metaintoimport.meta.urlandimport.meta.resolvesubsections. Expanded on their use cases.import()expressions sectionrequireof ES modules is not supported because ES modules are asynchronous.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes