Skip to content

util: fix to inspect getters that access this - #36052

Merged
Trott merged 1 commit into
nodejs:masterfrom
RaisinTen:fix-util-inspect-getter
Nov 12, 2020
Merged

util: fix to inspect getters that access this#36052
Trott merged 1 commit into
nodejs:masterfrom
RaisinTen:fix-util-inspect-getter

Conversation

@RaisinTen

@RaisinTenRaisinTen commented Nov 9, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Fixes: #36045

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the util Issues and PRs related to the built-in util module. label Nov 9, 2020
aduh95
aduh95 reviewed Nov 9, 2020
View reviewed changes
Comment threadlib/internal/util/inspect.js Outdated
@RaisinTen
RaisinTen marked this pull request as ready for review November 9, 2020 18:03
@RaisinTen
RaisinTenforce-pushed the fix-util-inspect-getter branch from b82514f to 45a5f4fCompareNovember 10, 2020 11:09
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 10, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Nov 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34323/

@RaisinTen@Trott
util: fix to inspect getters that access this
929c51f
Fixes: nodejs#36045
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#36052
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Trottforce-pushed the fix-util-inspect-getter branch from 45a5f4f to 929c51fCompareNovember 12, 2020 13:40
@Trott

Trott commented Nov 12, 2020

Copy link
Copy Markdown
Member

Landed in 929c51f

@Trott
Trott merged commit 929c51f into nodejs:masterNov 12, 2020
@RaisinTen
RaisinTen deleted the fix-util-inspect-getter branch November 12, 2020 13:44
@szmarczak

szmarczak commented Nov 12, 2020

Copy link
Copy Markdown
Member

Big thanks @RaisinTen 🎉

@RaisinTen

RaisinTen commented Nov 12, 2020

Copy link
Copy Markdown
MemberAuthor

@szmarczak you're welcome. 🙂

codebytere pushed a commit that referenced this pull request Nov 22, 2020
@RaisinTen@codebytere
util: fix to inspect getters that access this
4140f49
Fixes: #36045
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #36052
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebyterecodebytere mentioned this pull request Nov 22, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
@RaisinTen@BethGriggs
util: fix to inspect getters that access this
aa69d59
Fixes: #36045
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #36052
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@RaisinTen@BethGriggs
util: fix to inspect getters that access this
3517ced
Fixes: #36045
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #36052
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@RaisinTen@BethGriggs
util: fix to inspect getters that access this
dfb353b
Fixes: #36045
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #36052
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targostargos mentioned this pull request Jan 25, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.utilIssues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

util.inspect fails to log getters which access this

6 participants

@RaisinTen@nodejs-github-bot@Trott@szmarczak@addaleax@aduh95