Skip to content

crypto: fix format warning in AdditionalConfig - #36060

Merged
Trott merged 0 commit into
nodejs:masterfrom
RaisinTen:fix-format-string-warning-crypto
Nov 16, 2020
Merged

crypto: fix format warning in AdditionalConfig#36060
Trott merged 0 commit into
nodejs:masterfrom
RaisinTen:fix-format-string-warning-crypto

Conversation

@RaisinTen

@RaisinTenRaisinTen commented Nov 10, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Fixes:

../src/crypto/crypto_keygen.cc: In static member function‘static v8::Maybe<bool> node::crypto::SecretKeyGenTraits::AdditionalConfig(node::crypto::CryptoJobMode, const v8::FunctionCallbackInfo<v8::Value>&, unsigned int*, node::crypto::SecretKeyGenConfig*)’:
../src/crypto/crypto_keygen.cc:73:53: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘size_t {aka unsigned int}’ [-Wformat=]
static_cast<size_t>(INT_MAX)* CHAR_BIT);
^
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Nov 10, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/quic

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 10, 2020
@RaisinTen
RaisinTenforce-pushed the fix-format-string-warning-crypto branch 3 times, most recently from 967eee2 to 20e30c1CompareNovember 10, 2020 08:57
addaleax
addaleax approved these changes Nov 10, 2020
View reviewed changes
Comment threadsrc/crypto/crypto_keygen.cc Outdated
@RaisinTen
RaisinTenforce-pushed the fix-format-string-warning-crypto branch from 20e30c1 to fedce01CompareNovember 10, 2020 15:16
addaleax
addaleax approved these changes Nov 10, 2020
View reviewed changes
Comment threadsrc/crypto/crypto_keygen.cc Outdated
Comment threadsrc/crypto/crypto_keygen.cc Outdated
@RaisinTen
RaisinTenforce-pushed the fix-format-string-warning-crypto branch from e44d72f to 9d4acd9CompareNovember 10, 2020 15:28
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2020
@nodejs-github-bot

nodejs-github-bot commented Nov 12, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34368/

@nodejs-github-bot

nodejs-github-bot commented Nov 14, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34394/

@Trott

Trott commented Nov 16, 2020

Copy link
Copy Markdown
Member

Landed in db8af5d

@TrottTrott closed this Nov 16, 2020
@Trott
Trottforce-pushed the fix-format-string-warning-crypto branch from 9d4acd9 to db8af5dCompareNovember 16, 2020 14:46
@Trott
Trott merged commit db8af5d into nodejs:masterNov 16, 2020
@RaisinTen
RaisinTen deleted the fix-format-string-warning-crypto branch November 16, 2020 15:20
codebytere pushed a commit that referenced this pull request Nov 22, 2020
@RaisinTen@codebytere
crypto: fix format warning in AdditionalConfig
272fc79
Fixes warning: format ‘%lu’ expects argument of type ‘long unsigned
int’, but argument 4 has type ‘size_t {aka unsigned int}`
Co-authored-by: Anna Henningsen <github@addaleax.net>
PR-URL: #36060
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebyterecodebytere mentioned this pull request Nov 22, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@RaisinTen@nodejs-github-bot@Trott@jasnell@addaleax@richardlau@targos