Uh oh!
There was an error while loading. Please reload this page.
test: fix unreliable test-fs-write-file.js - #36102
Merged
Merged
Conversation
Trott
commented
Nov 12, 2020
MemberAuthor
Fast track? |
This comment has been minimized.
This comment has been minimized.
lpinca
approved these changes
Nov 12, 2020
richardlau
approved these changes
Nov 12, 2020
nodejs-github-bot
commented
Nov 12, 2020
Collaborator
The test uses a file name twice, causing unreliability in CI. In particular, it's failing a lot on the Raspberry Pi devices. Fixes: nodejs#36090 PR-URL: nodejs#36102 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Trott
commented
Nov 12, 2020
MemberAuthor
Landed in f03f7cb |
targos pushed a commit
to targos/node
that referenced
this pull request
Apr 30, 2021
The test uses a file name twice, causing unreliability in CI. In particular, it's failing a lot on the Raspberry Pi devices. Fixes: nodejs#36090 PR-URL: nodejs#36102 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Merged
Pranay180420 pushed a commit
to Pranay180420/Node.jsforme
that referenced
this pull request
Feb 17, 2025
The test uses a file name twice, causing unreliability in CI. In particular, it's failing a lot on the Raspberry Pi devices. Fixes: nodejs/node#36090 PR-URL: nodejs/node#36102 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test uses a file name twice, causing unreliability in CI. In
particular, it's failing a lot on the Raspberry Pi devices.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes