Skip to content

lib: set abort-controller toStringTag - #36115

Closed
benjamingr wants to merge 1 commit into
nodejs:masterfrom
benjamingr:abort-string-tag
Closed

lib: set abort-controller toStringTag#36115
benjamingr wants to merge 1 commit into
nodejs:masterfrom
benjamingr:abort-string-tag

Conversation

@benjamingr

@benjamingrbenjamingr commented Nov 14, 2020

Copy link
Copy Markdown
Member

Pretty small fix for AbortController/AbortSignal defining Symbol.toStringTag like we're supposed to. This already works on EventTarget, isn't a big deal and I think was probably just missed before :]

I am... not sure what to label PRs that touch only AbortController 🤷

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@benjamingrbenjamingr added the eventtarget Issues and PRs related to the EventTarget implementation. label Nov 14, 2020
aduh95
aduh95 approved these changes Nov 14, 2020
View reviewed changes
Comment threadlib/internal/abort_controller.js Outdated
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 16, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 16, 2020
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 17, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2020
@nodejs-github-bot

nodejs-github-bot commented Nov 17, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34431/

@nodejs-github-bot

nodejs-github-bot commented Nov 17, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34437/

@benjamingr

benjamingr commented Nov 17, 2020

Copy link
Copy Markdown
MemberAuthor

The CI failure from the rebase looks like a real failure, I'll fix this.

@benjamingrbenjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2020
@nodejs-github-bot

nodejs-github-bot commented Nov 19, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34459/

@nodejs-github-bot

nodejs-github-bot commented Nov 19, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34461/

@nodejs-github-bot

nodejs-github-bot commented Nov 19, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34463/

@benjamingrbenjamingr added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2020
@github-actionsgithub-actionsBot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 19, 2020
@github-actions

github-actionsBot commented Nov 19, 2020

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/36115
✔ Done loading data for nodejs/node/pull/36115
----------------------------------- PR info ------------------------------------
Title lib: set abort-controller toStringTag (#36115)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch benjamingr:abort-string-tag -> nodejs:master
Labels author ready, eventtarget
Commits 1
- lib: set abort-controller toStringTag
Committers 1
- Benjamin Gruenbaum PR-URL: https://github.com/nodejs/node/pull/36115
Reviewed-By: Rich Trott Reviewed-By: Antoine du Hamel Reviewed-By: Anna Henningsen ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36115
Reviewed-By: Rich Trott Reviewed-By: Antoine du Hamel Reviewed-By: Anna Henningsen --------------------------------------------------------------------------------
⚠ Commits were pushed since the last review:
⚠ - lib: set abort-controller toStringTag
✔ Last GitHub Actions successful
ℹ Last Full PR CI on 2020-11-19T11:25:22Z: https://ci.nodejs.org/job/node-test-pull-request/34463/
- Querying data for job/node-test-pull-request/34463/
✔ Build data downloaded
✔ Last Jenkins CI successful
ℹ This PR was created on Sat, 14 Nov 2020 11:48:37 GMT
✔ Approvals: 3
✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36115#pullrequestreview-530580303
✔ - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/36115#pullrequestreview-530582218
✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/36115#pullrequestreview-530807605
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/372460457

@benjamingrbenjamingr added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 19, 2020
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2020
@github-actions

github-actionsBot commented Nov 19, 2020

Copy link
Copy Markdown
Contributor

Landed in 2097ffd...d7bfa58

nodejs-github-bot pushed a commit that referenced this pull request Nov 19, 2020
@benjamingr@nodejs-github-bot
lib: set abort-controller toStringTag
d7bfa58
PR-URL: #36115
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@benjamingr
benjamingr deleted the abort-string-tag branch November 19, 2020 15:58
codebytere pushed a commit that referenced this pull request Nov 22, 2020
@benjamingr@codebytere
lib: set abort-controller toStringTag
d6ea12e
PR-URL: #36115
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebyterecodebytere mentioned this pull request Nov 22, 2020
Merged
@targostargos mentioned this pull request Apr 24, 2021
Closed
targos pushed a commit to targos/node that referenced this pull request Apr 30, 2021
@benjamingr@targos
lib: set abort-controller toStringTag
a2cf563
PR-URL: nodejs#36115
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Apr 30, 2021
@benjamingr@targos
lib: set abort-controller toStringTag
4cd9f39
PR-URL: #36115
Backport-PR-URL: #38386
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos added backported-to-v14.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-open-v14.x labels Apr 30, 2021
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

eventtargetIssues and PRs related to the EventTarget implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@benjamingr@nodejs-github-bot@jasnell@Trott@addaleax@aduh95@targos