Uh oh!
There was an error while loading. Please reload this page.
fs: remove experimental from promises.rmdir recursive - #36131
Closed
andersk wants to merge 1 commit into
Closed
Conversation
This was missed in commit 35b17d9. Refs: nodejs#34278 Refs: nodejs#35171 Signed-off-by: Anders Kaseorg <andersk@mit.edu>
4 tasks
benjamingr
approved these changes
Nov 16, 2020
benjamingr
commented
Nov 16, 2020
Member
I think the YAML immediately above needs to be updated, the |
ContributorAuthor
@benjamingr To be clear, you’re suggesting the addition of a No such entries were added in #35171, and I don’t think they should be necessary. The decision to remove experimental status means that we relinquish the right to quietly make backward incompatible changes. For a feature that has not had any previous backward incompatible changes, this relinquishment applies retroactively to all versions where it exists, and the result is the same as if the feature had never been experimental at all. If my reasoning is incorrect, let me know and I’ll be happy to add them. |
Trott
approved these changes
Nov 16, 2020
bcoe
approved these changes
Nov 16, 2020
Contributor
@andersk, @Trott, @benjamingr not sure if we need to add the |
lpinca
approved these changes
Nov 16, 2020
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Nov 17, 2020
nodejs-github-bot
commented
Nov 17, 2020
Collaborator
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/36131 ✔ Done loading data for nodejs/node/pull/36131 ----------------------------------- PR info ------------------------------------ Title fs: remove experimental from promises.rmdir recursive (#36131) Author Anders Kaseorg (@andersk, first-time contributor) Branch andersk:fs-promises-rmdir-recursive -> nodejs:master Labels author ready, doc, fs Commits 1 - fs: remove experimental from promises.rmdir recursive Committers 1 - Anders Kaseorg PR-URL: https://github.com/nodejs/node/pull/36131 Refs: https://github.com/nodejs/node/issues/34278 Refs: https://github.com/nodejs/node/pull/35171 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Rich Trott Reviewed-By: Ben Coe Reviewed-By: Luigi Pinca Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36131 Refs: https://github.com/nodejs/node/issues/34278 Refs: https://github.com/nodejs/node/pull/35171 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Rich Trott Reviewed-By: Ben Coe Reviewed-By: Luigi Pinca Reviewed-By: James M Snell -------------------------------------------------------------------------------- ✖ GitHub CI is still running ℹ Doc-only changes ℹ This PR was created on Mon, 16 Nov 2020 04:28:56 GMT ✔ Approvals: 5 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/36131#pullrequestreview-531104541 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36131#pullrequestreview-531392319 ✔ - Ben Coe (@bcoe): https://github.com/nodejs/node/pull/36131#pullrequestreview-531473309 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36131#pullrequestreview-531678115 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/36131#pullrequestreview-532649062 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/370844246 |
Contributor
Landed in d7bfa58...275aa68 |
nodejs-github-bot pushed a commit
that referenced
this pull request
Nov 19, 2020
This was missed in commit 35b17d9. Refs: #34278 Refs: #35171 Signed-off-by: Anders Kaseorg <andersk@mit.edu> PR-URL: #36131 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit
that referenced
this pull request
Nov 22, 2020
This was missed in commit 35b17d9. Refs: #34278 Refs: #35171 Signed-off-by: Anders Kaseorg <andersk@mit.edu> PR-URL: #36131 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Dec 10, 2020
This was missed in commit 35b17d9. Refs: #34278 Refs: #35171 Signed-off-by: Anders Kaseorg <andersk@mit.edu> PR-URL: #36131 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Dec 10, 2020
This was missed in commit 35b17d9. Refs: #34278 Refs: #35171 Signed-off-by: Anders Kaseorg <andersk@mit.edu> PR-URL: #36131 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Dec 15, 2020
This was missed in commit 35b17d9. Refs: #34278 Refs: #35171 Signed-off-by: Anders Kaseorg <andersk@mit.edu> PR-URL: #36131 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was missed in commit 35b17d9.
Refs: #34278
Refs: #35171
Checklist