Skip to content

Update url.md - #36147

Closed
aarock1234 wants to merge 1 commit into
nodejs:masterfrom
aarock1234:patch-1
Closed

Update url.md#36147
aarock1234 wants to merge 1 commit into
nodejs:masterfrom
aarock1234:patch-1

Conversation

@aarock1234

@aarock1234aarock1234 commented Nov 17, 2020

Copy link
Copy Markdown
Contributor

Add missing 's' to example URL.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Add missing 's' to example URL.
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Nov 17, 2020
@jasnelljasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 16, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 16, 2020
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

jasnell pushed a commit that referenced this pull request Dec 16, 2020
Add missing 's' to example URL.
PR-URL: #36147
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

Copy link
Copy Markdown
Member

Landed in b558075

@jasnelljasnell closed this Dec 16, 2020
targos pushed a commit that referenced this pull request Dec 21, 2020
Add missing 's' to example URL.
PR-URL: #36147
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Dec 22, 2020
targos pushed a commit that referenced this pull request May 1, 2021
Add missing 's' to example URL.
PR-URL: #36147
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.urlIssues and PRs related to the legacy built-in url module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@aarock1234@nodejs-github-bot@jasnell@Trott@benjamingr@lpinca@HarshithaKP