Skip to content

doc: provide additional context - #36201

Closed
mhdawson wants to merge 4 commits into
nodejs:masterfrom
mhdawson:values2
Closed

doc: provide additional context#36201
mhdawson wants to merge 4 commits into
nodejs:masterfrom
mhdawson:values2

Conversation

@mhdawson

@mhdawsonmhdawson commented Nov 20, 2020

Copy link
Copy Markdown
Member

In the discussion of #35323
it was suggested that we should add some
additional context/clarification.

Signed-off-by: Michael Dawson mdawson@devrus.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 20, 2020
@mhdawson

mhdawson commented Nov 20, 2020

Copy link
Copy Markdown
MemberAuthor

@MylesBorins is this along the lines of what you had in mind?

@Trott

Trott commented Nov 22, 2020

Copy link
Copy Markdown
Member

Ironically, the commit message has insufficient context. Maybe this?:

doc: add context for technical values

Trott
Trott reviewed Nov 22, 2020
View reviewed changes
Comment threaddoc/guides/technical-values.md Outdated
Trott
Trott reviewed Nov 22, 2020
View reviewed changes
Comment threaddoc/guides/technical-values.md Outdated
@mhdawsonmhdawson mentioned this pull request Nov 23, 2020
Closed
7 tasks
Trott
Trott reviewed Nov 25, 2020
View reviewed changes
Comment threaddoc/guides/technical-values.md Outdated
Trott
Trott reviewed Nov 25, 2020
View reviewed changes
Comment threaddoc/guides/technical-values.md Outdated
Trott
Trott reviewed Nov 25, 2020
View reviewed changes
Comment threaddoc/guides/technical-values.md Outdated

@TrottTrottNov 25, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think either "will change" or "will evolve" is sufficient.

Trott
Trott reviewed Nov 25, 2020
View reviewed changes
Comment threaddoc/guides/technical-values.md Outdated
@jasnell

jasnell commented Nov 25, 2020

Copy link
Copy Markdown
Member

It would be helpful if the commit log / PR would contain more information about what the additional context is being added to :-)

@mhdawson
doc: provide more context on techinical values
d0a5290
In the discussion of nodejs#35323
it was suggested that we should add some
additional context/clarification to the technical
values documented for the project.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
@mhdawson

mhdawson commented Nov 26, 2020

Copy link
Copy Markdown
MemberAuthor

@jasnell updated

@mhdawson
squash: address comments
9a4499c
Signed-off-by: Michael Dawson <mdawson@devrus.com>
@mhdawson

mhdawson commented Nov 30, 2020

Copy link
Copy Markdown
MemberAuthor

@MylesBorins if you can take a look would be good to confirm the concern you had.

MylesBorins
MylesBorins approved these changes Dec 2, 2020
View reviewed changes

@MylesBorinsMylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson

mhdawson commented Dec 2, 2020

Copy link
Copy Markdown
MemberAuthor

@mmarchini any chance you can review/approve since you were in the meeting were we discussed as well?

Trott
Trott reviewed Dec 4, 2020
View reviewed changes
Comment threaddoc/guides/technical-values.md Outdated
Trott
Trott reviewed Dec 4, 2020
View reviewed changes
Comment threaddoc/guides/technical-values.md Outdated
mhdawsonand others added 2 commits December 7, 2020 16:37
@mhdawson@Trott
Update doc/guides/technical-values.md
0c8b8d0
Co-authored-by: Rich Trott <rtrott@gmail.com>
@mhdawson@Trott
Update doc/guides/technical-values.md
eb37468
Co-authored-by: Rich Trott <rtrott@gmail.com>
@mhdawson

mhdawson commented Dec 7, 2020

Copy link
Copy Markdown
MemberAuthor

Linters have passed, landing

mhdawson added a commit that referenced this pull request Dec 7, 2020
@mhdawson
doc: provide more context on techinical values
6d3775e
In the discussion of #35323
it was suggested that we should add some
additional context/clarification to the technical
values documented for the project.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #36201
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@mhdawson

mhdawson commented Dec 7, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in 6d3775e

@mhdawsonmhdawson closed this Dec 7, 2020
targos pushed a commit that referenced this pull request Dec 21, 2020
@mhdawson@targos
doc: provide more context on techinical values
6a6b3af
In the discussion of #35323
it was suggested that we should add some
additional context/clarification to the technical
values documented for the project.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #36201
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targostargos mentioned this pull request Dec 22, 2020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@mhdawson@targos
doc: provide more context on techinical values
cd06521
In the discussion of #35323
it was suggested that we should add some
additional context/clarification to the technical
values documented for the project.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #36201
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
+1 more reviewer
@MylesBorinsMylesBorinsMylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mhdawson@Trott@jasnell@MylesBorins@nodejs-github-bot