Skip to content

benchmark : changed fstat to fstatSync - #36206

Closed
Narasimha1997 wants to merge 1 commit into
nodejs:masterfrom
Narasimha1997:benchmark-fstat
Closed

benchmark : changed fstat to fstatSync#36206
Narasimha1997 wants to merge 1 commit into
nodejs:masterfrom
Narasimha1997:benchmark-fstat

Conversation

@Narasimha1997

@Narasimha1997Narasimha1997 commented Nov 21, 2020•
edited by aduh95
Loading

Copy link
Copy Markdown
Contributor

Changed fstat to fstatSync as mentioned in the issue #36199

Fixes: #36199

@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. fs Issues and PRs related to the fs subsystem / file system. labels Nov 21, 2020
@aduh95
aduh95 requested a review from mscdexNovember 21, 2020 12:56
@gireeshpunathilgireeshpunathil mentioned this pull request Nov 23, 2020
Closed
2 tasks
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2020•
edited by aduh95
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34555/ ✅

@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 25, 2020
@gireeshpunathilgireeshpunathil added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2020
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2020
@github-actions

github-actionsBot commented Nov 26, 2020

Copy link
Copy Markdown
Contributor

Landed in 2b21a31...49abda7

nodejs-github-bot pushed a commit that referenced this pull request Nov 26, 2020
@Narasimha1997@nodejs-github-bot
benchmark : changed fstat to fstatSync
49abda7
PR-URL: #36206Fixes: #36199
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gireeshpunathil

gireeshpunathil commented Nov 26, 2020

Copy link
Copy Markdown
Member

thanks @Narasimha1997 for the contribution! 🎉

@Narasimha1997

Narasimha1997 commented Nov 26, 2020

Copy link
Copy Markdown
ContributorAuthor

@gireeshpunathil ,
Thank you so much. Looking forword to contribute and learn more in the coming days.

danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@Narasimha1997@danielleadams
benchmark : changed fstat to fstatSync
2344e3e
PR-URL: #36206Fixes: #36199
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Dec 7, 2020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Narasimha1997@targos
benchmark : changed fstat to fstatSync
2bbf253
PR-URL: #36206Fixes: #36199
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@mscdexmscdexAwaiting requested review from mscdex
@aduh95aduh95Awaiting requested review from aduh95

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

benchmark: dead code

7 participants

@Narasimha1997@nodejs-github-bot@gireeshpunathil@jasnell@Trott@lpinca@aduh95