Uh oh!
There was an error while loading. Please reload this page.
doc: adding example to Buffer.isBuffer method update buffer.md file - #36233
doc: adding example to Buffer.isBuffer method update buffer.md file #36233ntedgi wants to merge 5 commits into
Conversation
ntedgi
commented
Nov 23, 2020
following our conversion here at #36209 (comment) |
benjamingr
left a comment
There was a problem hiding this comment.
I would make these examples much shorter probably?
Buffer.isBuffer(Buffer.alloc(10));// trueBuffer.isBuffer(Buffer.from('foo'));// trueBuffer.isBuffer('a string');// falseBuffer.isBuffer([]);// falseBuffer.isBuffer(newUint8Array(1024));// falsentedgi
commented
Nov 23, 2020
update according to your suggestions |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Commit Queue failed- Loading data for nodejs/node/pull/36233 ✔ Done loading data for nodejs/node/pull/36233 ----------------------------------- PR info ------------------------------------ Title doc : adding example to Buffer.isBuffer method update buffer.md file (#36233) Author Naor Tedgi (Abu Emma) (@ntedgi, first-time contributor) Branch ntedgi:doc-buffer-static-method-buffer-isbuffer-obj-example -> nodejs:master Labels buffer, doc Commits 5 - doc : adding example to Buffer.isBuffer method update buffer.md file - remove description - fix linting missing semi - update review suggestions writing shorter tests - remove separat lines Committers 1 - naortedgi PR-URL: https://github.com/nodejs/node/pull/36233 Reviewed-By: Gireesh Punathil Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Juan José Arboleda Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36233 Reviewed-By: Gireesh Punathil Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Juan José Arboleda Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Doc-only changes ℹ This PR was created on Mon, 23 Nov 2020 07:39:08 GMT ✔ Approvals: 5 ✔ - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/36233#pullrequestreview-536237166 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/36233#pullrequestreview-536386558 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36233#pullrequestreview-536406210 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/36233#pullrequestreview-536476851 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36233#pullrequestreview-537455462 -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 36233 From https://github.com/nodejs/node * branch refs/pull/36233/merge -> FETCH_HEAD ✔ Fetched commits as 4c97325c4e33..10e4d5dc21a0 -------------------------------------------------------------------------------- [master 4c0c0f00c1] doc : adding example to Buffer.isBuffer method update buffer.md file Author: naortedgi Date: Mon Nov 23 09:34:53 2020 +0200 1 file changed, 20 insertions(+), 1 deletion(-) [master 58dc655de5] remove description Author: naortedgi Date: Mon Nov 23 09:37:19 2020 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [master 56af25f43c] fix linting missing semi Author: naortedgi Date: Mon Nov 23 09:42:45 2020 +0200 1 file changed, 2 insertions(+), 2 deletions(-) [master 0a0b4a724d] update review suggestions writing shorter tests Author: naortedgi Date: Mon Nov 23 13:05:47 2020 +0200 1 file changed, 5 insertions(+), 15 deletions(-) [master dd7f2e6801] remove separat lines Author: naortedgi Date: Mon Nov 23 14:03:46 2020 +0200 1 file changed, 2 deletions(-) ✔ Patches applied There are 5 commits in the PR. Attempting autorebase. Rebasing (2/10)https://github.com/nodejs/node/actions/runs/384668227 |
PR-URL: #36233 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
gireeshpunathil
commented
Nov 26, 2020
landed in 2b21a31 , thanks for the contribution! 🎉 |
PR-URL: #36233 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #36233 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
update buffer.md file adding example to Buffer.isBuffer method