Uh oh!
There was an error while loading. Please reload this page.
tools: use using-declaration consistently - #36245
Closed
danbev wants to merge 2 commits into
Closed
Conversation
nodejs-github-bot
commented
Nov 24, 2020
Collaborator
richardlau
approved these changes
Nov 24, 2020
nodejs-github-bot
commented
Nov 24, 2020
Collaborator
cjihrig
approved these changes
Nov 24, 2020
danbev
commented
Nov 25, 2020
ContributorAuthor
Re-run of failing node-test-commit-linux-containered ✔️ |
jasnell
reviewed
Nov 25, 2020
Uh oh!
There was an error while loading. Please reload this page.
jasnell
approved these changes
Nov 25, 2020
lpinca
approved these changes
Nov 25, 2020
gireeshpunathil
approved these changes
Nov 26, 2020
danbev added a commit
that referenced
this pull request
Nov 27, 2020
PR-URL: #36245 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danbev
commented
Nov 27, 2020
ContributorAuthor
Landed in 0a23d65. |
danielleadams pushed a commit
that referenced
this pull request
Dec 7, 2020
PR-URL: #36245 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes