Skip to content

build: enable building with shared uvwasi lib - #36257

Closed
PoojaDurgad wants to merge 1 commit into
nodejs:mainfrom
PoojaDurgad:config-uvwasi
Closed

build: enable building with shared uvwasi lib#36257
PoojaDurgad wants to merge 1 commit into
nodejs:mainfrom
PoojaDurgad:config-uvwasi

Conversation

@PoojaDurgad

@PoojaDurgadPoojaDurgad commented Nov 25, 2020

Copy link
Copy Markdown
Contributor

Fixes: #35339

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the build Issues and PRs related to build files or the CI. label Nov 25, 2020
@PoojaDurgad

PoojaDurgad commented Nov 25, 2020

Copy link
Copy Markdown
ContributorAuthor

I was not able to test it successfully because it needs a external library . please suggest

richardlau
richardlau reviewed Nov 25, 2020
View reviewed changes
Comment threadnode.gyp Outdated
@PoojaDurgad

PoojaDurgad commented Nov 25, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@richardlau -I get this error and don't know how to resolve this.

/usr/bin/ld: /home/pooja/node/out/Release/obj.target/libnode/src/node_binding.o: infunction`node::binding::RegisterBuiltinModules()':node_binding.cc:(.text+0x150a): undefined reference to `_register_wasi()'
collect2: error: ldreturned1exitstatus```

richardlau
richardlau reviewed Nov 25, 2020
View reviewed changes
Comment threadnode.gyp Outdated
richardlau
richardlau reviewed Nov 26, 2020
View reviewed changes
Comment threadnode.gypi Outdated
Trott
Trott reviewed Nov 28, 2020
View reviewed changes
Comment threadconfigure.py Outdated
@Trott

Trott commented Dec 2, 2020

Copy link
Copy Markdown
Member

If GitHub Actions are to be trusted, this breaks the build in its current state.

image

@Trott
Trott marked this pull request as draft December 2, 2020 17:07
@Trott

Trott commented Dec 2, 2020

Copy link
Copy Markdown
Member

I changed this to a draft. Feel free to change it back whenever you think it's ready, but I'd guess it's a draft until the build is working.

@richardlaurichardlau mentioned this pull request Jul 25, 2022
Closed
@TeutatesTeutates mentioned this pull request Jul 25, 2022
Closed
@PoojaDurgad@Teutates@aduh95
build: enable building with shared uvwasi lib
797ff57
Fixes: nodejs#35339
Co-authored-by: Pooja D P <Pooja.D.P@ibm.com>
Co-authored-by: Teutates <103068388+Teutates@users.noreply.github.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95
aduh95 marked this pull request as ready for review May 11, 2024 13:35
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 11, 2024
@nodejs-github-bot

nodejs-github-bot commented May 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59099/

@nodejs-github-bot

nodejs-github-bot commented May 12, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59143/

@aduh95

aduh95 commented May 12, 2024

Copy link
Copy Markdown
Contributor

Superseded by #43987

@aduh95aduh95 closed this May 12, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott left review comments
@richardlaurichardlaurichardlau left review comments

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable building with shared uvwasi library.

5 participants

@PoojaDurgad@Trott@nodejs-github-bot@aduh95@richardlau