Skip to content

worker: refactor to use more primordials - #36267

Closed
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:worker-primordials
Closed

worker: refactor to use more primordials#36267
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:worker-primordials

Conversation

@aduh95

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the worker Issues and PRs related to Worker support. label Nov 25, 2020
@Trott

Copy link
Copy Markdown
Member

@aduh95

Copy link
Copy Markdown
ContributorAuthor

Benchmark results doesn't show any performance improvement or regression.

Details
 confidence improvement accuracy (*) (**) (***)
worker/atomics-wait.js n=10000000 -2.15 % ±2.22% ±2.95% ±3.84%
worker/bench-eventlooputil.js method='ELU_passed' n=1000000 -0.14 % ±1.44% ±1.91% ±2.49%
worker/bench-eventlooputil.js method='ELU_simple' n=1000000 0.38 % ±3.33% ±4.44% ±5.80%
worker/echo.js n=100000 sendsPerBroadcast=10 payload='object' workers=1 1.55 % ±4.94% ±6.58% ±8.57%
worker/echo.js n=100000 sendsPerBroadcast=10 payload='string' workers=1 -1.38 % ±4.03% ±5.36% ±6.98%
worker/echo.js n=100000 sendsPerBroadcast=1 payload='object' workers=1 2.37 % ±3.69% ±4.92% ±6.40%
worker/echo.js n=100000 sendsPerBroadcast=1 payload='string' workers=1 -2.52 % ±3.59% ±4.77% ±6.22%
worker/messageport.js n=1000000 style='eventemitter' payload='object' 0.21 % ±3.09% ±4.11% ±5.36%
worker/messageport.js n=1000000 style='eventemitter' payload='string' 0.82 % ±3.38% ±4.52% ±5.91%
worker/messageport.js n=1000000 style='eventtarget' payload='object' 2.40 % ±2.76% ±3.67% ±4.78%
worker/messageport.js n=1000000 style='eventtarget' payload='string' -1.09 % ±3.53% ±4.69% ±6.11%
14:56:36 14:56:36 Be aware that when doing many comparisons the risk of a false-positive
14:56:36 result increases. In this case there are 11 comparisons, you can thus
14:56:36 expect the following amount of false-positive results:
0.55 false positives, when considering a 5% risk acceptance (*, **, ***),
0.11 false positives, when considering a 1% risk acceptance (**, ***),
0.01 false positives, when considering a 0.1% risk acceptance (***)

@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2020
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 29, 2020
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 2, 2020
@github-actions

Copy link
Copy Markdown
Contributor

Landed in f066ae4...325a1fc

nodejs-github-bot pushed a commit that referenced this pull request Dec 2, 2020
PR-URL: #36267
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95
aduh95 deleted the worker-primordials branch December 2, 2020 20:23
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
PR-URL: #36267
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Dec 7, 2020
targos pushed a commit that referenced this pull request May 16, 2021
PR-URL: #36267
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targostargos mentioned this pull request Jun 6, 2021
targos pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #36267
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.workerIssues and PRs related to Worker support.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@aduh95@Trott@nodejs-github-bot