Skip to content

test: fix flaky test-http2-respond-file-error-pipe-offset - #36305

Merged
Trott merged 0 commit into
nodejs:masterfrom
Trott:sprig
Dec 7, 2020
Merged

test: fix flaky test-http2-respond-file-error-pipe-offset#36305
Trott merged 0 commit into
nodejs:masterfrom
Trott:sprig

Conversation

@Trott

@TrottTrott commented Nov 28, 2020

Copy link
Copy Markdown
Member

Fixes: #35881

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 28, 2020
@TrottTrott mentioned this pull request Nov 28, 2020
Closed
@TrottTrott changed the title test: fix falky test-http2-respond-file-error-pipe-offsettest: fix flaky test-http2-respond-file-error-pipe-offsetNov 28, 2020
@Trott
Trott requested a review from addaleaxNovember 28, 2020 16:38
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@szmarczak

szmarczak commented Dec 2, 2020

Copy link
Copy Markdown
Member

Can't we use a UNIX socket instead?

@Trott

Trott commented Dec 2, 2020

Copy link
Copy Markdown
MemberAuthor

Can't we use a UNIX socket instead?

I'm under the impression that the test is specifically for an issue involving pipes, but I could be wrong. /ping @addaleax

addaleax
addaleax approved these changes Dec 2, 2020
View reviewed changes

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, as would be using a socket. The important thing is that the target file is not seekable.

@nodejs-github-bot

nodejs-github-bot commented Dec 3, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34729/

@nodejs-github-bot

nodejs-github-bot commented Dec 4, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34742/

@nodejs-github-bot

nodejs-github-bot commented Dec 4, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34748/

@nodejs-github-bot

nodejs-github-bot commented Dec 5, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34767/

@TrottTrott closed this Dec 7, 2020
@Trott
Trott merged commit f178c5a into nodejs:masterDec 7, 2020
@Trott

Trott commented Dec 7, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in f178c5a

@Trott
Trott deleted the sprig branch December 7, 2020 15:31
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@Trott@danielleadams
test: fix flaky test-http2-respond-file-error-pipe-offset
a7e794d
Fixes: #35881
PR-URL: #36305
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danielleadamsdanielleadams mentioned this pull request Dec 7, 2020
Merged
targos pushed a commit that referenced this pull request Apr 25, 2021
@Trott@targos
test: fix flaky test-http2-respond-file-error-pipe-offset
cd1da67
Fixes: #35881
PR-URL: #36305
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

investigate flaky test-http2-respond-file-error-pipe-offset

4 participants

@Trott@nodejs-github-bot@szmarczak@addaleax