Uh oh!
There was an error while loading. Please reload this page.
src: rename AliasedBufferInfo->AliasedBufferIndex - #36339
Closed
danbev wants to merge 1 commit into
Closed
Conversation
This commit suggest renaming AlaisedBufferInfo to AlaisedBufferIndex to make the code more readable. The main motivation for this change is that I personally think that the following code could be a little clearer: context->GetDataFromSnapshotOnce<V8T>(*info_).ToLocalChecked(); Even knowing that GetDataFromSnapshotOnce takes a size_t I had to double check the type of info_ to make sure.
himself65
approved these changes
Dec 3, 2020
Trott
approved these changes
Dec 3, 2020
nodejs-github-bot
commented
Dec 3, 2020
Collaborator
danbev
commented
Dec 4, 2020
ContributorAuthor
Landed in e4614e8. |
danbev added a commit
that referenced
this pull request
Dec 4, 2020
This commit suggest renaming AlaisedBufferInfo to AlaisedBufferIndex to make the code more readable. The main motivation for this change is that I personally think that the following code could be a little clearer: context->GetDataFromSnapshotOnce<V8T>(*info_).ToLocalChecked(); Even knowing that GetDataFromSnapshotOnce takes a size_t I had to double check the type of info_ to make sure. PR-URL: #36339 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Dec 7, 2020
This commit suggest renaming AlaisedBufferInfo to AlaisedBufferIndex to make the code more readable. The main motivation for this change is that I personally think that the following code could be a little clearer: context->GetDataFromSnapshotOnce<V8T>(*info_).ToLocalChecked(); Even knowing that GetDataFromSnapshotOnce takes a size_t I had to double check the type of info_ to make sure. PR-URL: #36339 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit suggest renaming
AlaisedBufferInfotoAlaisedBufferIndextomake the code more readable.
The main motivation for this change is that I personally think that
the following code could be a little clearer:
context->GetDataFromSnapshotOnce<V8T>(*info_).ToLocalChecked();Even knowing that
GetDataFromSnapshotOncetakes asize_tI had to doublecheck the type of info_ to make sure.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes