Uh oh!
There was an error while loading. Please reload this page.
domains: emit uncaughtException when appropriate - #3640
Closed
misterdjules wants to merge 1 commit into
Closed
Conversation
misterdjulesforce-pushed
the
fix-issue-3607-master
branch
from
November 3, 2015 02:02
6d1f73c to
04b75caComparemisterdjulesforce-pushed
the
fix-issue-3607-master
branch
from
November 3, 2015 06:40
04b75ca to
f5ffc5aCompare
Fix node exiting due to an exception being thrown rather than emitting an `'uncaughtException'` event on the process object when no error handler is set on the domain within which an error is thrown and an `'uncaughtException'` event listener is set on the process. Fixesnodejs#3607.
misterdjulesforce-pushed
the
fix-issue-3607-master
branch
from
November 3, 2015 06:42
f5ffc5a to
bb645c2CompareContributor
There was a problem hiding this comment.
Should this be test-domain-uncaught-exception.js? Seems more explicit.
misterdjules
commented
Nov 4, 2015
Author
Closing in favor of #3654. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix node exiting due to an exception being thrown rather than emitting
an
'uncaughtException'event on the process object when no errorhandler is set on the domain within which an error is thrown and an
'uncaughtException'event listener is set on the process.Fixes#3607.
/cc @nodejs/tsc @nodejs/collaborators.