Skip to content

build,lib,test: change whitelist to allowlist - #36406

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:allowlist
Closed

build,lib,test: change whitelist to allowlist#36406
targos wants to merge 1 commit into
nodejs:masterfrom
targos:allowlist

Conversation

@targos

@targostargos commented Dec 6, 2020

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-botnodejs-github-bot added the build Issues and PRs related to build files or the CI. label Dec 6, 2020
@addaleaxaddaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2020
@nodejs-github-bot

nodejs-github-bot commented Dec 6, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34789/

@nodejs-github-bot

nodejs-github-bot commented Dec 6, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34793/

@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2020
@nodejs-github-bot

nodejs-github-bot commented Dec 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34829/

@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34885/

@richardlaurichardlau mentioned this pull request Dec 10, 2020
Closed
3 tasks
mhdawson
mhdawson approved these changes Dec 11, 2020
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot

nodejs-github-bot commented Dec 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34893/

@mhdawson

mhdawson commented Dec 11, 2020

Copy link
Copy Markdown
Member

Resume build - https://ci.nodejs.org/job/node-test-pull-request/34893/

@mhdawson

mhdawson commented Dec 11, 2020

Copy link
Copy Markdown
Member

Build good landing

@mhdawson

mhdawson commented Dec 11, 2020

Copy link
Copy Markdown
Member

Landed in 7e5bf48

mhdawson pushed a commit that referenced this pull request Dec 11, 2020
@targos@mhdawson
build,lib,test: change whitelist to allowlist
7e5bf48
PR-URL: #36406
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@targos
targos deleted the allowlist branch December 11, 2020 05:54
targos added a commit that referenced this pull request Dec 21, 2020
@targos
build,lib,test: change whitelist to allowlist
1330995
PR-URL: #36406
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@targostargos mentioned this pull request Dec 22, 2020
Merged
targos added a commit that referenced this pull request May 1, 2021
@targos
build,lib,test: change whitelist to allowlist
9ccf7db
PR-URL: #36406
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@targos@nodejs-github-bot@mhdawson@Trott@addaleax@lpinca@cjihrig